From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [PULL 0/8] Ide patches
Date: Thu, 3 Oct 2019 13:26:15 -0400 [thread overview]
Message-ID: <bf8fe3f9-5d38-7c77-81a0-6382ce1bdbee@redhat.com> (raw)
In-Reply-To: <CAFEAcA8q2UgQNxO41CGyAS=c7sb9V-v8kvcBFRZ9wW67Q7eo-w@mail.gmail.com>
On 10/3/19 11:35 AM, Peter Maydell wrote:
> On Wed, 2 Oct 2019 at 00:56, John Snow <jsnow@redhat.com> wrote:
>>
>> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
>>
>> Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01 13:13:38 +0100)
>>
>> are available in the Git repository at:
>>
>> https://github.com/jnsnow/qemu.git tags/ide-pull-request
>>
>> for you to fetch changes up to d5eedf4633376d22a34a17a061d3ed47ddb6fee0:
>>
>> hd-geo-test: Add tests for lchs override (2019-10-01 17:50:16 -0400)
>>
>> ----------------------------------------------------------------
>> "IDE" Pull request. (CHS changes for SeaBios)
>>
>> ----------------------------------------------------------------
>>
>> Sam Eiderman (8):
>> block: Refactor macros - fix tabbing
>> block: Support providing LCHS from user
>> bootdevice: Add interface to gather LCHS
>> scsi: Propagate unrealize() callback to scsi-hd
>> bootdevice: Gather LCHS from all relevant devices
>> bootdevice: Refactor get_boot_devices_list
>> bootdevice: FW_CFG interface for LCHS values
>> hd-geo-test: Add tests for lchs override
>
> Hi John -- it looks like you forgot to put your signed-off-by
> as the maintainer on the commits in this pullreq. Could you
> fix that and resend, please?
>
... I see what happened now, actually.
The emails got signed but the commits didn't.
I didn't sign them when I applied the patches, but I signed them when
using git-publish --pull-request --signoff, and it applies the signature
before send, but after mirroring.
I'll try to fix that when I have the time to make sure it doesn't happen
again.
--js
prev parent reply other threads:[~2019-10-03 17:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 23:55 [PULL 0/8] Ide patches John Snow
2019-10-01 23:55 ` [PULL 1/8] block: Refactor macros - fix tabbing John Snow
2019-10-01 23:55 ` [PULL 2/8] block: Support providing LCHS from user John Snow
2019-10-01 23:55 ` [PULL 3/8] bootdevice: Add interface to gather LCHS John Snow
2019-10-01 23:55 ` [PULL 4/8] scsi: Propagate unrealize() callback to scsi-hd John Snow
2019-10-01 23:55 ` [PULL 5/8] bootdevice: Gather LCHS from all relevant devices John Snow
2019-10-01 23:55 ` [PULL 6/8] bootdevice: Refactor get_boot_devices_list John Snow
2019-10-01 23:55 ` [PULL 7/8] bootdevice: FW_CFG interface for LCHS values John Snow
2019-10-01 23:55 ` [PULL 8/8] hd-geo-test: Add tests for lchs override John Snow
2019-10-02 5:52 ` [PULL 0/8] Ide patches no-reply
2019-10-02 18:03 ` John Snow
2019-10-03 15:35 ` Peter Maydell
2019-10-03 17:21 ` John Snow
2019-10-03 17:26 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf8fe3f9-5d38-7c77-81a0-6382ce1bdbee@redhat.com \
--to=jsnow@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).