From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVvDC-0001ud-AO for qemu-devel@nongnu.org; Fri, 14 Jul 2017 03:40:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVvD7-0008Eb-Ez for qemu-devel@nongnu.org; Fri, 14 Jul 2017 03:40:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60608) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVvD7-0008Dm-8p for qemu-devel@nongnu.org; Fri, 14 Jul 2017 03:40:25 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01D9FC0587D4 for ; Fri, 14 Jul 2017 07:40:24 +0000 (UTC) From: Jason Wang References: <03f93e78-b585-6d01-2c63-5de8dac97abe@redhat.com> <20170711145456.GT7116@redhat.com> Message-ID: Date: Fri, 14 Jul 2017 15:40:19 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Michal Privoznik Cc: qemu-devel@nongnu.org On 2017=E5=B9=B407=E6=9C=8814=E6=97=A5 15:31, Jason Wang wrote: > > > On 2017=E5=B9=B407=E6=9C=8811=E6=97=A5 22:54, Daniel P. Berrange wrote: >> On Tue, Jul 11, 2017 at 03:10:43PM +0200, Michal Privoznik wrote: >>> On 06/22/2017 05:58 PM, Michal Privoznik wrote: >>>> On 05/30/2017 10:23 AM, Michal Privoznik wrote: >>>>> For more description see patch 3. Long story short, if the bridge=20 >>>>> helper runs >>>>> with SUID, the mechanism we rely on (DAC denying access to ACL=20 >>>>> files) does not >>>>> work. >>>>> >>>>> Michal Privoznik (3): >>>>> qemu-bridge-helper: Reverse return value setting logic >>>>> qemu-bridge-helper: Reverse return value setting logic in >>>>> parse_acl_file >>>>> qemu-bridge-helper: Take ACL file gid into account >>>>> >>>>> qemu-bridge-helper.c | 79=20 >>>>> ++++++++++++++++++++++++++++------------------------ >>>>> 1 file changed, 42 insertions(+), 37 deletions(-) >>>>> >>>> ping? >>>> >>> ping^2? > > Applied. Just notice Daniel's comment. Michal, can you please address that? Thanks > >> Sigh, this is one of the files for which we have no nominated maintain= er >> listed, so it easily falls through the cracks. >> >> Since this is network related, I wonder if Jason should be listed in t= he >> MAINTAINERS file for this. Or perhaps we should move the=20 >> qemu-bridge-helper.c >> file into the net/ sub-directory instead ? > > Let me claim this in MAINTAINERS. > > Thanks > >> >> Regards, >> Daniel > >