From: "Cédric Le Goater" <clg@redhat.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>, qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, eric.auger@redhat.com,
nicolinc@nvidia.com, joao.m.martins@oracle.com,
yi.l.liu@intel.com, chao.p.peng@intel.com
Subject: Re: [PATCH v2 0/5] vfio: Move realize after attach_dev
Date: Wed, 23 Apr 2025 15:35:28 +0200 [thread overview]
Message-ID: <bfa00057-3e92-4042-b1e1-cf1e3dfc48da@redhat.com> (raw)
In-Reply-To: <ec9f9453-bd15-450b-b602-91fdfcc340b1@redhat.com>
On 4/23/25 15:21, Cédric Le Goater wrote:
> On 4/23/25 09:28, Zhenzhong Duan wrote:
>> Hi,
>>
>> This series addresses Cédric's suggestion[1] and Donald's suggestion[2] to
>> move realize() call after attach_device().
>>
>> This way avoid the need to introduce realize_late() to further complex the
>> interface in nesting series.
>>
>> [1] https://lists.gnu.org/archive/html/qemu-devel/2025-04/msg01211.html
>> [2] https://lists.gnu.org/archive/html/qemu-devel/2025-04/msg00898.html
>>
>> Test:
>> net card passthrough and ping test
>> hotplug/unplug
>>
>> Based on vfio-next(856f36c005).
>>
>> Thanks
>> Zhenzhong
>>
>> Changelog:
>> v2:
>> - drop the idea to save host iommu capabilities in VFIODevice.caps
>> - introduce a new function to create and realize hiod
>> - remove hiod_typename property
>>
>> Zhenzhong Duan (5):
>> vfio/iommufd: Make a separate call to get IOMMU capabilities
>> vfio/iommufd: Move realize() after attachment
>> vfio/container: Move realize() after attachment
>> vfio: Cleanup host IOMMU device creation
>> vfio: Remove hiod_typename property
>>
>> include/hw/vfio/vfio-container-base.h | 3 ---
>> include/hw/vfio/vfio-device.h | 3 ++-
>> hw/vfio/container.c | 25 ++++++++++++--------
>> hw/vfio/device.c | 33 ++++++++++++---------------
>> hw/vfio/iommufd.c | 31 +++++++++++++------------
>> 5 files changed, 47 insertions(+), 48 deletions(-)
>>
>
> Reviewed-by: Cédric Le Goater <clg@redhat.com>
Applied to vfio-next.
Thanks,
C.
prev parent reply other threads:[~2025-04-23 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 7:28 [PATCH v2 0/5] vfio: Move realize after attach_dev Zhenzhong Duan
2025-04-23 7:28 ` [PATCH v2 1/5] vfio/iommufd: Make a separate call to get IOMMU capabilities Zhenzhong Duan
2025-04-23 8:31 ` Joao Martins
2025-04-23 7:28 ` [PATCH v2 2/5] vfio/iommufd: Move realize() after attachment Zhenzhong Duan
2025-04-23 9:39 ` Joao Martins
2025-04-23 7:28 ` [PATCH v2 3/5] vfio/container: " Zhenzhong Duan
2025-04-23 7:28 ` [PATCH v2 4/5] vfio: Cleanup host IOMMU device creation Zhenzhong Duan
2025-04-23 7:28 ` [PATCH v2 5/5] vfio: Remove hiod_typename property Zhenzhong Duan
2025-04-23 13:21 ` [PATCH v2 0/5] vfio: Move realize after attach_dev Cédric Le Goater
2025-04-23 13:35 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa00057-3e92-4042-b1e1-cf1e3dfc48da@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=eric.auger@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=nicolinc@nvidia.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).