From: Collin Walling <walling@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: david@redhat.com, qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init
Date: Tue, 12 Feb 2019 12:02:50 -0500 [thread overview]
Message-ID: <bfa7b77d-9c01-0bba-ec25-7b4162a35de3@linux.ibm.com> (raw)
In-Reply-To: <20190212110439.38e3fbb2.cohuck@redhat.com>
On 2/12/19 5:04 AM, Cornelia Huck wrote:
> On Mon, 11 Feb 2019 20:16:55 -0500
> Collin Walling <walling@linux.ibm.com> wrote:
>
>> The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent
>> on the multiple-epoch facility (mepoch). Let's print a warning if these
>> features are enabled without mepoch.
>>
>> While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down
>> the s390_feature_groups list so it can be properly indexed with its
>> generated S390FeatGroup enum.
>>
>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>> ---
>> target/s390x/cpu_features.c | 2 +-
>> target/s390x/cpu_models.c | 4 ++++
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> Not a comment for this patch (looks fine to me), but more general:
> Could you please add a cover letter if you send more than one patch?
> It's easy to miss that there are three patches and not two :)
>
Noted. Thanks for the advice!
--
Respectfully,
- Collin Walling
next prev parent reply other threads:[~2019-02-12 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 1:16 [Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init Collin Walling
2019-02-12 1:16 ` [Qemu-devel] [PATCH v2 2/3] s390x/cpumodel: default enable mepoch for z14 and later Collin Walling
2019-02-12 9:04 ` David Hildenbrand
2019-02-12 17:03 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-02-13 9:47 ` [Qemu-devel] " Cornelia Huck
2019-02-12 1:16 ` [Qemu-devel] [PATCH v2 3/3] s390x/cpumodel: add z14 GA2 model Collin Walling
2019-02-13 9:48 ` Cornelia Huck
2019-02-12 10:04 ` [Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init Cornelia Huck
2019-02-12 17:02 ` Collin Walling [this message]
2019-02-12 10:09 ` Christian Borntraeger
2019-02-12 17:03 ` Collin Walling
2019-02-12 19:35 ` David Hildenbrand
2019-02-13 9:45 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa7b77d-9c01-0bba-ec25-7b4162a35de3@linux.ibm.com \
--to=walling@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).