Re: [Qemu-devel] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 12/10/18 4:10 PM, Laszlo Ersek wrote:
> On 12/07/18 17:51, Philippe Mathieu-Daudé wrote:
>> SMBIOS is just another firmware used by some QEMU models.
>> We will later introduce more firmwares in this namespace.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS                              | 2 +-
>>  hw/arm/virt.c                            | 2 +-
>>  hw/i386/pc.c                             | 2 +-
>>  hw/i386/pc_piix.c                        | 2 +-
>>  hw/i386/pc_q35.c                         | 2 +-
>>  hw/smbios/smbios-stub.c                  | 2 +-
>>  hw/smbios/smbios.c                       | 2 +-
>>  hw/smbios/smbios_type_38.c               | 2 +-
>>  include/hw/{smbios => firmware}/smbios.h | 0
>>  tests/bios-tables-test.c                 | 2 +-
>>  vl.c                                     | 2 +-
>>  11 files changed, 10 insertions(+), 10 deletions(-)
>>  rename include/hw/{smbios => firmware}/smbios.h (100%)
> 
> (1) Please replace the word "namespace" in the subject, and in the
> commit message too, with "subdirectory".
> 
> (2) Please replace "firmware" -- both instances -- in the commit message
> with "firmware interface", or perhaps "firmware specification".

I'll go with "firmware interface", because I'd like to eventually put
here helpers for firmwares with no public specification.

> With the updates:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks,
> Laszlo