From: Richard Henderson <richard.henderson@linaro.org>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: "Vanderson M . do Rosario" <vandersonmr2@gmail.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/1] tcg: add perfmap and jitdump
Date: Sun, 8 Jan 2023 14:26:30 -0800 [thread overview]
Message-ID: <bfae98eb-43e3-afe3-be69-105bd44870ec@linaro.org> (raw)
In-Reply-To: <20221114161321.3364875-2-iii@linux.ibm.com>
On 11/14/22 08:13, Ilya Leoshkevich wrote:
> -const void *tcg_splitwx_to_rx(void *rw);
> +const void *tcg_splitwx_to_rx(const void *rw);
> void *tcg_splitwx_to_rw(const void *rx);
> #else
> -static inline const void *tcg_splitwx_to_rx(void *rw)
> +static inline const void *tcg_splitwx_to_rx(const void *rw)
This is incorrect, or at least not as designed.
The idea is that any rw pointer is not const, and any rx pointer is const, and this
declaration prevents double-conversion.
r~
next prev parent reply other threads:[~2023-01-08 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 16:13 [PATCH v2 0/1] tcg: add perfmap and jitdump Ilya Leoshkevich
2022-11-14 16:13 ` [PATCH v2 1/1] " Ilya Leoshkevich
2023-01-06 17:31 ` Alex Bennée
2023-01-08 22:26 ` Richard Henderson [this message]
2023-01-03 12:36 ` PING: [PATCH v2 0/1] " Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfae98eb-43e3-afe3-be69-105bd44870ec@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=vandersonmr2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).