From: Eric Blake <eblake@redhat.com>
To: "Claudio Fontana" <cfontana@suse.de>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
qemu-devel@nongnu.org
Subject: Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user
Date: Tue, 16 Feb 2021 13:34:17 -0600 [thread overview]
Message-ID: <bfc83c84-5626-cc49-2387-60df46a41b4c@redhat.com> (raw)
In-Reply-To: <20210216104647.13400-14-cfontana@suse.de>
On 2/16/21 4:46 AM, Claudio Fontana wrote:
In the subject, s/slit/split/
> XXX Should we assert that cpu hidden flag SVME is not set,
> when attempting to generate VMRUN and related instructions
> in CONFIG_USER_ONLY?
>
> XXX Similarily, should we check for CONFIG_USER_ONLY when
> attempting to cpu_load_efer?
If you don't fix the comment, s/Similarily/Similarly/
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-02-16 19:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 10:46 [RFC v19 00/15] i386 cleanup PART 2 Claudio Fontana
2021-02-16 10:46 ` [RFC v19 01/15] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-02-16 10:46 ` [RFC v19 02/15] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-02-16 10:46 ` [RFC v19 03/15] accel: introduce new accessor functions Claudio Fontana
2021-02-16 10:46 ` [RFC v19 04/15] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-02-16 10:46 ` [RFC v19 05/15] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-02-16 10:46 ` [RFC v19 06/15] meson: add target_user_arch Claudio Fontana
2021-02-16 10:46 ` [RFC v19 07/15] i386: split off softmmu-only functionality in tcg-cpu Claudio Fontana
2021-02-16 10:46 ` [RFC v19 08/15] i386: split smm helper (softmmu) Claudio Fontana
2021-02-16 10:46 ` [RFC v19 09/15] i386: split tcg excp_helper into softmmu and user parts Claudio Fontana
2021-02-16 10:46 ` [RFC v19 10/15] i386: move TCG btp_helper into softmmu/ Claudio Fontana
2021-02-16 11:58 ` Claudio Fontana
2021-02-16 17:36 ` Paolo Bonzini
2021-02-16 10:46 ` [RFC v19 11/15] i386: split misc helper into user and softmmu parts Claudio Fontana
2021-02-16 10:46 ` [RFC v19 12/15] i386: separate fpu_helper " Claudio Fontana
2021-02-16 10:46 ` [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user Claudio Fontana
2021-02-16 10:52 ` Claudio Fontana
2021-02-16 10:58 ` Paolo Bonzini
2021-02-16 10:58 ` Paolo Bonzini
2021-02-16 19:34 ` Eric Blake [this message]
2021-02-16 20:44 ` Claudio Fontana
2021-02-16 10:46 ` [RFC v19 14/15] i386: split seg_helper into user-only and softmmu parts Claudio Fontana
2021-02-16 10:46 ` [RFC v19 15/15] i386: split off softmmu part of cpu.c Claudio Fontana
2021-02-16 11:06 ` [RFC v19 00/15] i386 cleanup PART 2 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfc83c84-5626-cc49-2387-60df46a41b4c@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).