From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F05CDB47E for ; Fri, 20 Oct 2023 03:31:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtgE5-0001Gr-Iy; Thu, 19 Oct 2023 23:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtgE3-0001Ge-HQ for qemu-devel@nongnu.org; Thu, 19 Oct 2023 23:31:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtgE1-0007pn-Eb for qemu-devel@nongnu.org; Thu, 19 Oct 2023 23:31:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697772660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwkfzHSmZLcc0o3kmcFFCOXnHCgsl8JobHXWPtCKYUg=; b=c58SVLyrE7oF8EfTeBMGffAjHseFvxsnKop7bS7GNPnPvVZ+PQitPAjXXVjKtMMcqTA1m9 yIGQFjyb3+nVr8Nu0cm8iwxwVGMuvoxQuCL3zyD5EdjMeK4BnbmPJsXVsgP5d+XEmpAuYF zKh1pRM8ciDnumRaZnnGCJcbcTw+4rc= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-nJV5QsjSORONDj2hhERpXA-1; Thu, 19 Oct 2023 23:30:53 -0400 X-MC-Unique: nJV5QsjSORONDj2hhERpXA-1 Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-6ce2908d14dso96113a34.0 for ; Thu, 19 Oct 2023 20:30:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697772653; x=1698377453; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NwkfzHSmZLcc0o3kmcFFCOXnHCgsl8JobHXWPtCKYUg=; b=B+3o+RiHVKKTKsCeBFNBf650M+0/PBD0jo0i54ElHoOxvks8ZKZxABAVRpMYi4T5Iv 9P+uO2zD0vTtSD1ZvExeZqrPtBOocfYssQgZQ6Yn/S2VXpvyyfkllf5PpK3E+MVivoyu x3bx+V0n9S54LcU4M0M7xVXOhNfULDwSTr70TzkxWqNZb20iHEzHAkvozU7qYMO1guPT oO1dyQf1qOG6PcjUS81cTTF7O4+9gTvYnOxmSyuUmIpABSzIURwlYXRDTWevErbRgebl eG+2OXC1WiDe/icuAARNpCabh3n4bBVTo9LTS/E5ryBez92LccoOG2Cs8+mpPeZSwnG2 X/cw== X-Gm-Message-State: AOJu0Yy2iciY/EME0aUJntwHk+L3koh9iZAxoEUklFKHdf9IuVcq7rBA F1AU8az+QQWoqNB4w1ZUaODAXC6zy1DMPZ47WTh4dm7fnswC7rVt5UKoJdAyP1YL0WTh7FwFgzq AeVgIA3dE4oIrgGA= X-Received: by 2002:a05:6830:16c9:b0:6b1:9646:2ea0 with SMTP id l9-20020a05683016c900b006b196462ea0mr841451otr.1.1697772652932; Thu, 19 Oct 2023 20:30:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuWMAyxtugwFJMeNgeGetuIwAkQwSIk4QTARhFk7GfiPOVzeYgleMSGXHAQLNgzMrz4qv9Gg== X-Received: by 2002:a05:6830:16c9:b0:6b1:9646:2ea0 with SMTP id l9-20020a05683016c900b006b196462ea0mr841439otr.1.1697772652653; Thu, 19 Oct 2023 20:30:52 -0700 (PDT) Received: from [10.66.61.39] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id x190-20020a6263c7000000b006b5b46e4098sm521768pfb.169.2023.10.19.20.30.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 20:30:52 -0700 (PDT) Message-ID: Date: Fri, 20 Oct 2023 11:30:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug Content-Language: en-US To: Salil Mehta , "qemu-devel@nongnu.org" , "qemu-arm@nongnu.org" Cc: "maz@kernel.org" , "jean-philippe@linaro.org" , Jonathan Cameron , "lpieralisi@kernel.org" , "peter.maydell@linaro.org" , "richard.henderson@linaro.org" , "imammedo@redhat.com" , "andrew.jones@linux.dev" , "david@redhat.com" , "philmd@linaro.org" , "eric.auger@redhat.com" , "oliver.upton@linux.dev" , "pbonzini@redhat.com" , "mst@redhat.com" , "will@kernel.org" , "gshan@redhat.com" , "rafael@kernel.org" , "alex.bennee@linaro.org" , "linux@armlinux.org.uk" , "darren@os.amperecomputing.com" , "ilkka@os.amperecomputing.com" , "vishnu@os.amperecomputing.com" , "karl.heubaum@oracle.com" , "miguel.luis@oracle.com" , "salil.mehta@opnsrc.net" , zhukeqian , "wangxiongfeng (C)" , "wangyanan (Y)" , "jiakernel2@gmail.com" , "maobibo@loongson.cn" , "lixianglai@loongson.cn" , Linuxarm References: <20231013105129.25648-1-salil.mehta@huawei.com> <262138951966462dbc7f05a5efa146d6@huawei.com> From: Shaoqin Huang In-Reply-To: <262138951966462dbc7f05a5efa146d6@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=shahuang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.339, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/19/23 17:34, Salil Mehta wrote: > Hi Shaoqin, > >> From: Shaoqin Huang >> Sent: Thursday, October 19, 2023 10:05 AM >> To: Salil Mehta ; qemu-devel@nongnu.org; qemu- >> arm@nongnu.org >> Cc: maz@kernel.org; jean-philippe@linaro.org; Jonathan Cameron >> ; lpieralisi@kernel.org; >> peter.maydell@linaro.org; richard.henderson@linaro.org; >> imammedo@redhat.com; andrew.jones@linux.dev; david@redhat.com; >> philmd@linaro.org; eric.auger@redhat.com; oliver.upton@linux.dev; >> pbonzini@redhat.com; mst@redhat.com; will@kernel.org; gshan@redhat.com; >> rafael@kernel.org; alex.bennee@linaro.org; linux@armlinux.org.uk; >> darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; >> vishnu@os.amperecomputing.com; karl.heubaum@oracle.com; >> miguel.luis@oracle.com; salil.mehta@opnsrc.net; zhukeqian >> ; wangxiongfeng (C) ; >> wangyanan (Y) ; jiakernel2@gmail.com; >> maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm >> Subject: Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU >> Hotplug >> >> >> >> On 10/13/23 18:51, Salil Mehta via wrote: >>> Virtual CPU hotplug support is being added across various >> architectures[1][3]. >>> This series adds various code bits common across all architectures: >>> >>> 1. vCPU creation and Parking code refactor [Patch 1] >>> 2. Update ACPI GED framework to support vCPU Hotplug [Patch 4,6,7] >>> 3. ACPI CPUs AML code change [Patch 5] >>> 4. Helper functions to support unrealization of CPU objects [Patch 8,9] >>> 5. Misc [Patch 2,3] >>> >>> >>> Repository: >>> >>> [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc- >> v2.common.v6 >>> >>> >>> Revision History: >>> >>> Patch-set V5 -> V6 >>> 1. Addressed Gavin Shan's comments >>> - Fixed the assert() ranges of address spaces >>> - Rebased the patch-set to latest changes in the qemu.git >>> - Added Reviewed-by tags for patches {8,9} >>> 2. Addressed Jonathan Cameron's comments >>> - Updated commit-log for [Patch V5 1/9] with mention of trace events >>> - Added Reviewed-by tags for patches {1,5} >>> 3. Added Tested-by tags from Xianglai Li >>> 4. Fixed checkpatch.pl error "Qemu -> QEMU" in [Patch V5 1/9] >>> Link: https://lore.kernel.org/qemu-devel/20231011194355.15628-1- >> salil.mehta@huawei.com/ >>> >>> Patch-set V4 -> V5 >>> 1. Addressed Gavin Shan's comments >>> - Fixed the trace events print string for >> kvm_{create,get,park,destroy}_vcpu >>> - Added Reviewed-by tag for patch {1} >>> 2. Added Shaoqin Huang's Reviewed-by tags for Patches {2,3} >>> 3. Added Tested-by Tag from Vishnu Pajjuri to the patch-set >>> 4. Dropped the ARM specific [Patch V4 10/10] >>> Link: https://lore.kernel.org/qemu-devel/20231009203601.17584-1- >> salil.mehta@huawei.com/ >>> >>> Patch-set V3 -> V4 >>> 1. Addressed David Hilderbrand's comments >>> - Fixed the wrong doc comment of kvm_park_vcpu API prototype >>> - Added Reviewed-by tags for patches {2,4} >>> Link: https://lore.kernel.org/qemu-devel/20231009112812.10612-1- >> salil.mehta@huawei.com/ >>> >>> Patch-set V2 -> V3 >>> 1. Addressed Jonathan Cameron's comments >>> - Fixed 'vcpu-id' type wrongly changed from 'unsigned long' to >> 'integer' >>> - Removed unnecessary use of variable 'vcpu_id' in kvm_park_vcpu >>> - Updated [Patch V2 3/10] commit-log with details of >> ACPI_CPU_SCAN_METHOD macro >>> - Updated [Patch V2 5/10] commit-log with details of conditional >> event handler method >>> - Added Reviewed-by tags for patches {2,3,4,6,7} >>> 2. Addressed Gavin Shan's comments >>> - Remove unnecessary use of variable 'vcpu_id' in kvm_par_vcpu >>> - Fixed return value in kvm_get_vcpu from -1 to -ENOENT >>> - Reset the value of 'gdb_num_g_regs' in >> gdb_unregister_coprocessor_all >>> - Fixed the kvm_{create,park}_vcpu prototypes docs >>> - Added Reviewed-by tags for patches {2,3,4,5,6,7,9,10} >>> 3. Addressed one earlier missed comment by Alex Bennée in RFC V1 >>> - Added traces instead of DPRINTF in the newly added and some >> existing functions >>> Link: https://lore.kernel.org/qemu-devel/20230930001933.2660-1- >> salil.mehta@huawei.com/ >>> >>> Patch-set V1 -> V2 >>> 1. Addressed Alex Bennée's comments >>> - Refactored the kvm_create_vcpu logic to get rid of goto >>> - Added the docs for kvm_{create,park}_vcpu prototypes >>> - Splitted the gdbstub and AddressSpace destruction change into >> separate patches >>> - Added Reviewed-by tags for patches {2,10} >>> Link: https://lore.kernel.org/qemu-devel/20230929124304.13672-1- >> salil.mehta@huawei.com/ >>> >>> References: >>> >>> [1] https://lore.kernel.org/qemu-devel/20230926100436.28284-1- >> salil.mehta@huawei.com/ >>> [2] https://lore.kernel.org/all/20230913163823.7880-1- >> james.morse@arm.com/ >>> [3] https://lore.kernel.org/qemu- >> devel/cover.1695697701.git.lixianglai@loongson.cn/ >>> >>> >>> Salil Mehta (9): >>> accel/kvm: Extract common KVM vCPU {creation,parking} code >>> hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file >>> hw/acpi: Add ACPI CPU hotplug init stub >>> hw/acpi: Init GED framework with CPU hotplug events >>> hw/acpi: Update CPUs AML with cpu-(ctrl)dev change >>> hw/acpi: Update GED _EVT method AML with CPU scan >>> hw/acpi: Update ACPI GED framework to support vCPU Hotplug >>> physmem: Add helper function to destroy CPU AddressSpace >>> gdbstub: Add helper function to unregister GDB register space >>> >>> accel/kvm/kvm-all.c | 64 ++++++++++++++++++++------ >>> accel/kvm/trace-events | 4 ++ >>> gdbstub/gdbstub.c | 12 +++++ >>> hw/acpi/acpi-cpu-hotplug-stub.c | 6 +++ >>> hw/acpi/cpu.c | 27 +++++++---- >>> hw/acpi/generic_event_device.c | 22 +++++++++ >>> hw/i386/acpi-build.c | 3 +- >>> include/exec/cpu-common.h | 8 ++++ >>> include/exec/gdbstub.h | 5 ++ >>> include/hw/acpi/cpu.h | 5 +- >>> include/hw/acpi/cpu_hotplug.h | 4 ++ >>> include/hw/acpi/generic_event_device.h | 5 ++ >>> include/hw/core/cpu.h | 1 + >>> include/sysemu/kvm.h | 16 +++++++ >>> system/physmem.c | 29 ++++++++++++ >>> 15 files changed, 184 insertions(+), 27 deletions(-) >>> >> >> Hi salil, >> >> All patches looks good to me. Thanks for you effort to update it so >> actively. No issues being found by simply testing and several daily use. >> >> Reviewed-by: Shaoqin Huang > > Many thanks! Just wanted to confirm if you have tested this patch over > x86 platform as well? Hi Salil, I used it on Ampere One Machine, so didn't test it on x86 platform. Thanks, Shaoqin > > > Cheers > Salil. -- Shaoqin