From: Richard Henderson <richard.henderson@linaro.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: thuth@redhat.com, david@redhat.com, cohuck@redhat.com,
qemu-devel@nongnu.org, Ulrich Weigand <ulrich.weigand@de.ibm.com>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL
Date: Wed, 30 Jun 2021 06:32:42 -0700 [thread overview]
Message-ID: <bfd0db3d-284b-dcca-bc80-306fbdf9cc7a@linaro.org> (raw)
In-Reply-To: <20210630104926.GB29019@oc3748833570.ibm.com>
On 6/30/21 3:49 AM, Ulrich Weigand wrote:
>> I'm thinking that should be able to remove TCGv_i32 cc_op in the
>> translator and manually write back to the slot instead. We already
>> do a good job of caching the value within DisasContext -- I imagine
>> that the final code wouldn't even change too much.
>
> I see. If this works out, I'll update my patch accordingly
> -- please let me know.
I posted that on Monday:
https://patchew.org/QEMU/20210629002930.3013776-1-richard.henderson@linaro.org/
There are actually slightly fewer stores to the cc_op slot in the generated code, because
some of them migrate to the helpers. But for normal integer code the generated *is*
identical.
r~
prev parent reply other threads:[~2021-06-30 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 16:35 [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL Ulrich Weigand
2021-06-28 18:45 ` Richard Henderson
2021-06-30 10:49 ` Ulrich Weigand
2021-06-30 13:32 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd0db3d-284b-dcca-bc80-306fbdf9cc7a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=ulrich.weigand@de.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).