From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org
Subject: Re: [PATCH] storage-daemon: include current command line option in the errors
Date: Fri, 26 Feb 2021 07:44:06 -0600 [thread overview]
Message-ID: <bfd3670a-e686-aea2-2d43-702b6a1bd406@redhat.com> (raw)
In-Reply-To: <20210226110312.157645-1-pbonzini@redhat.com>
On 2/26/21 5:03 AM, Paolo Bonzini wrote:
> Use the location management facilities that the emulator uses, so that
> the current command line option appears in the error message.
>
> Before:
>
> $ storage-daemon/qemu-storage-daemon --nbd key..=
> qemu-storage-daemon: Invalid parameter 'key..'
>
> After:
>
> $ storage-daemon/qemu-storage-daemon --nbd key..=
> qemu-storage-daemon: --nbd key..=: Invalid parameter 'key..'
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> storage-daemon/qemu-storage-daemon.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-02-26 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 11:03 [PATCH] storage-daemon: include current command line option in the errors Paolo Bonzini
2021-02-26 13:44 ` Eric Blake [this message]
2021-03-01 12:26 ` Kevin Wolf
2021-03-01 15:09 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd3670a-e686-aea2-2d43-702b6a1bd406@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).