From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DA0C433E0 for ; Thu, 4 Jun 2020 13:24:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C172207DF for ; Thu, 4 Jun 2020 13:24:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i+MFJJjM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C172207DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgprI-0001GN-BU for qemu-devel@archiver.kernel.org; Thu, 04 Jun 2020 09:24:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgpqM-0000Sb-9U for qemu-devel@nongnu.org; Thu, 04 Jun 2020 09:23:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:31593 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jgpqL-0003Tn-6C for qemu-devel@nongnu.org; Thu, 04 Jun 2020 09:23:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591277016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rP34Pf8Rx6TCxpREpfeSpM5B7D1PGOkQooz36LREW7g=; b=i+MFJJjMEj2LvcBAMUOkzt0ZK8+OJ0s+iLe5mWxtyXVa6bPp8133wfq5VFu7S8PTD3IxaU Q12ZXzWLzsjFLktqZTsFgd3Nd/looSKkuy88xmWLgq6CjeHRA8pdqP9zUESFUw07rUEHkM Xq+IvrtaPqZm8QKukTJXxRaA3QkSwSg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-8WmFceadPzapK7SIAVoHSQ-1; Thu, 04 Jun 2020 09:23:34 -0400 X-MC-Unique: 8WmFceadPzapK7SIAVoHSQ-1 Received: by mail-wm1-f70.google.com with SMTP id x6so1999451wmj.9 for ; Thu, 04 Jun 2020 06:23:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rP34Pf8Rx6TCxpREpfeSpM5B7D1PGOkQooz36LREW7g=; b=GDXOkCrZSRQbVDDZKTzbumR3C5iUmy0GNcMq7ef0fWPNphtfMPIILdyhRdrSmwWYoo igpvpU/foX/qZ4hsrnZbKa+dbzVUn56HHUCBIIqwyYSY4xjXHvt/GyBog7C3tjx2ylYm AXh4SZuzjfkm2/bcmmqAQdohkr5TCg5okQ4sB/qeLr9StTSKGxieR3j2TbZKNPAf8kxG ASsDemHiUM6IGskpUdeD63Q+mVggny5nHdmlwvD7pp2vCWUthFFnQe22Z6lACQJG2/wp 57VjK59ksocsRdDQqQ8Ek/FkeIpHnk9anKLBZqJukJEylexD8I1XM2H8Vl2rg3zeGhHw 9biw== X-Gm-Message-State: AOAM531g73nXEVj9Fb6BD+9VxxWyhKbOSZvJXH3zjC0Lepdd3WwWClFX qVQzCcUlagohW6EbwUhQVcUGIVkFQxhLCiK1JiPiWVUpc3ei6HRb5J3t+lAc2AKeD4cAbjJ6Wh4 W3/zNcXhimE/A7ts= X-Received: by 2002:a5d:4bcb:: with SMTP id l11mr4775452wrt.363.1591277013507; Thu, 04 Jun 2020 06:23:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxk3ryicpFw2SPJTKmOwr0/VAmtH3/6BI0DlnawzGVxUcHjhMMnwRocxxIaDKNkcr1zkezDNg== X-Received: by 2002:a5d:4bcb:: with SMTP id l11mr4775431wrt.363.1591277013308; Thu, 04 Jun 2020 06:23:33 -0700 (PDT) Received: from [192.168.1.43] (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id v28sm8896415wra.77.2020.06.04.06.23.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 06:23:32 -0700 (PDT) Subject: Re: [PATCH v2 6/7] vga: build virtio-gpu only once To: Gerd Hoffmann , qemu-devel@nongnu.org References: <20200604131643.1776-1-kraxel@redhat.com> <20200604131643.1776-7-kraxel@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Thu, 4 Jun 2020 15:23:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200604131643.1776-7-kraxel@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/04 01:12:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dinechin@redhat.com, Paolo Bonzini , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/4/20 3:16 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/display/Makefile.objs | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs > index 76b3571e4902..d619594ad4d3 100644 > --- a/hw/display/Makefile.objs > +++ b/hw/display/Makefile.objs > @@ -49,12 +49,12 @@ common-obj-m += qxl.mo > qxl.mo-objs = qxl.o qxl-logger.o qxl-render.o > endif > > -obj-$(CONFIG_VIRTIO_GPU) += virtio-gpu-base.o virtio-gpu.o virtio-gpu-3d.o > -obj-$(CONFIG_VHOST_USER_GPU) += vhost-user-gpu.o > -obj-$(call land,$(CONFIG_VIRTIO_GPU),$(CONFIG_VIRTIO_PCI)) += virtio-gpu-pci.o > -obj-$(call land,$(CONFIG_VHOST_USER_GPU),$(CONFIG_VIRTIO_PCI)) += vhost-user-gpu-pci.o > -obj-$(CONFIG_VIRTIO_VGA) += virtio-vga.o > -obj-$(CONFIG_VHOST_USER_VGA) += vhost-user-vga.o > +common-obj-$(CONFIG_VIRTIO_GPU) += virtio-gpu-base.o virtio-gpu.o virtio-gpu-3d.o > +common-obj-$(CONFIG_VHOST_USER_GPU) += vhost-user-gpu.o > +common-obj-$(call land,$(CONFIG_VIRTIO_GPU),$(CONFIG_VIRTIO_PCI)) += virtio-gpu-pci.o > +common-obj-$(call land,$(CONFIG_VHOST_USER_GPU),$(CONFIG_VIRTIO_PCI)) += vhost-user-gpu-pci.o > +common-obj-$(CONFIG_VIRTIO_VGA) += virtio-vga.o > +common-obj-$(CONFIG_VHOST_USER_VGA) += vhost-user-vga.o > virtio-gpu.o-cflags := $(VIRGL_CFLAGS) > virtio-gpu.o-libs += $(VIRGL_LIBS) > virtio-gpu-3d.o-cflags := $(VIRGL_CFLAGS) > Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé