From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver
Date: Thu, 7 Feb 2019 22:33:40 +0100 [thread overview]
Message-ID: <bfda8184-db4e-ac05-2054-cb33fc45f1bb@redhat.com> (raw)
In-Reply-To: <20190207193605.25676-2-crosa@redhat.com>
On 2/7/19 8:36 PM, Cleber Rosa wrote:
> This looks like a leftover that was never implemented.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> configure | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/configure b/configure
> index fbd0825488..ff55e2273e 100755
> --- a/configure
> +++ b/configure
> @@ -3350,10 +3350,6 @@ for drv in $audio_drv_list; do
> oss_libs="$oss_lib"
> ;;
>
> - wav)
> - # XXX: Probes for CoreAudio, DirectSound
> - ;;
> -
> *)
> echo "$audio_possible_drivers" | grep -q "\<$drv\>" || {
> error_exit "Unknown driver '$drv' selected" \
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-02-07 21:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 19:36 [Qemu-devel] [PATCH 0/4] Trivial fixes for configure and Python scripts Cleber Rosa
2019-02-07 19:36 ` [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver Cleber Rosa
2019-02-07 20:05 ` Laurent Vivier
2019-02-07 21:33 ` Philippe Mathieu-Daudé [this message]
2019-02-14 9:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-07 19:36 ` [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name Cleber Rosa
2019-02-07 20:11 ` Laurent Vivier
2019-02-07 21:36 ` Philippe Mathieu-Daudé
2019-02-14 9:44 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-07 19:36 ` [Qemu-devel] [PATCH 3/4] scripts/render_block_graph.py: add a missing import Cleber Rosa
2019-02-07 19:36 ` [Qemu-devel] [PATCH 4/4] tests/migration/guestperf/engine.py: remove unused import Cleber Rosa
2019-02-14 9:46 ` [Qemu-devel] [Qemu-trivial] [PATCH 0/4] Trivial fixes for configure and Python scripts Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfda8184-db4e-ac05-2054-cb33fc45f1bb@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).