qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Libvirt <libvir-list@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 03/14] audio: -audiodev command line option: documentation
Date: Tue, 29 Jan 2019 07:13:46 +0100	[thread overview]
Message-ID: <bfdf1243-9bf1-128a-3f6d-93e425a0839c@redhat.com> (raw)
In-Reply-To: <92b6dc0f167f0c0f53ad9c0fbf127ea255b7429f.1548714862.git.DirtY.iCE.hu@gmail.com>

On 2019-01-28 23:43, Kővágó, Zoltán wrote:
> This patch adds documentation of an -audiodev command line option, that
> deprecates the old QEMU_* environment variables for audio backend
> configuration.  It's syntax is similar to existing options (-netdev,
> -device, etc):
> 
>   -audiodev driver_name,property=value,...
> 
> Although now it's possible to specify multiple -audiodev options on
> command line, multiple audio backends are not supported yet.
> 
> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
> ---
>  qemu-options.hx | 222 +++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 219 insertions(+), 3 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 521511ec13..a12931899b 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -416,14 +416,230 @@ The default is @code{en-us}.
>  ETEXI
>  
>  
> +HXCOMM Deprecated by -audiodev
>  DEF("audio-help", 0, QEMU_OPTION_audio_help,
> -    "-audio-help     print list of audio drivers and their options\n",
> +    "-audio-help     show -audiodev equivalent of the currently specified audio settings\n",
>      QEMU_ARCH_ALL)

Note that if you want to deprecate a parameter "officially" (in the
sense that it could be removed in a future release), you also have to
add an entry to qemu-deprecated.texi. But that could also be done in an
additional patch later, so no need to respin just because of this.

 Thomas

  reply	other threads:[~2019-01-29  6:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 22:43 [Qemu-devel] [PATCH v4 00/14] Audio patches (was: Audio 5.1 patches) Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 01/14] qapi: qapi for audio backends Kővágó, Zoltán
2019-01-29 13:33   ` Markus Armbruster
2019-02-07 20:26     ` Zoltán Kővágó
2019-01-29 15:52   ` Markus Armbruster
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 02/14] audio: use qapi AudioFormat instead of audfmt_e Kővágó, Zoltán
2019-01-29  6:22   ` Thomas Huth
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 03/14] audio: -audiodev command line option: documentation Kővágó, Zoltán
2019-01-29  6:13   ` Thomas Huth [this message]
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 04/14] audio: -audiodev command line option basic implementation Kővágó, Zoltán
2019-01-29 15:56   ` Markus Armbruster
2019-02-07 20:29     ` Zoltán Kővágó
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 05/14] alsaaudio: port to -audiodev config Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 06/14] coreaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 07/14] dsoundaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 08/14] noaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 09/14] ossaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 10/14] paaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 11/14] sdlaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 12/14] spiceaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 13/14] wavaudio: " Kővágó, Zoltán
2019-01-28 22:43 ` [Qemu-devel] [PATCH v4 14/14] audio: -audiodev command line option: cleanup Kővágó, Zoltán
2019-01-31 17:56 ` [Qemu-devel] [PATCH v4 00/14] Audio patches (was: Audio 5.1 patches) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfdf1243-9bf1-128a-3f6d-93e425a0839c@redhat.com \
    --to=thuth@redhat.com \
    --cc=dirty.ice.hu@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).