From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2 00/14] PPC440 devices misc clean up
Date: Thu, 6 Jul 2023 04:13:01 -0300 [thread overview]
Message-ID: <c00e7c46-6928-ed4d-f2c6-2754a590802f@gmail.com> (raw)
In-Reply-To: <ec526143-9f3f-3d8d-9977-2ee76a31ef23@eik.bme.hu>
On 7/5/23 22:09, BALATON Zoltan wrote:
> On Wed, 5 Jul 2023, Daniel Henrique Barboza wrote:
>> Zoltan,
>>
>> Patches 1-9 are queued. Don't need to re-send those.
>
> Thanks, the last two patches are also reviewed and they don't depend on the ones before so you could queue those too.
Just queued patch 13.
Patch 14 doesn't apply in ppc-next even after applying patch 13:
$ git am -s -m \[PATCH\ v2\ 14_14\]\ ppc440_pcix\:\ Stop\ using\ system\ io\ region\ for\ PCI\ bus\ -\ BALATON\ Zoltan\ \<balaton@eik.bme.hu\>\ -\ 2023-07-05\ 1712.eml
Applying: ppc440_pcix: Stop using system io region for PCI bus
error: patch failed: hw/ppc/ppc440_pcix.c:490
error: hw/ppc/ppc440_pcix.c: patch does not apply
error: patch failed: hw/ppc/sam460ex.c:441
error: hw/ppc/sam460ex.c: patch does not apply
Patch failed at 0001 ppc440_pcix: Stop using system io region for PCI bus
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
I suspect we need some of the previous (10, 11, 12) to apply it cleanly.
Thanks,
Daniel
>
> The only outstanding patches are those 3 that rename the type defines to match their string values. We could come up with better names but those suggested by Philippe are too long IMO so at least the patches in this series clean up the current mess and we could rename these later. I'd rather not change the string values too much as those are what QOM actually uses to ideintify the types but we're free to change the defines. Currently we have:
> #define TYPE_PPC4xx_PCI_HOST_BRIDGE "ppc4xx-pcihost"
> and then a "ppc4xx-host-bridge" type without a define which is another type which is quite confusing. I may have partly created this mess back when I first tried to add sam460ex and did not know much about this but at least I'd like to improve it a little and resolve some of it now.
>
> Regards,
> BALATON Zoltan
next prev parent reply other threads:[~2023-07-06 7:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 20:12 [PATCH v2 00/14] PPC440 devices misc clean up BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 01/14] ppc440: Change ppc460ex_pcie_init() parameter type BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 02/14] ppc440: Add cpu link property to PCIe controller model BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 03/14] ppc440: Add a macro to shorten PCIe controller DCR registration BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 04/14] ppc440: Rename parent field of PPC460EXPCIEState to match code style BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 05/14] ppc440: Rename local variable in dcr_read_pcie() BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 06/14] ppc440: Stop using system io region for PCIe buses BALATON Zoltan
2023-07-05 20:31 ` Philippe Mathieu-Daudé
2023-07-05 20:12 ` [PATCH v2 07/14] ppc/sam460ex: Remove address_space_mem local variable BALATON Zoltan
2023-07-06 0:46 ` Daniel Henrique Barboza
2023-07-05 20:12 ` [PATCH v2 08/14] ppc440: Add busnum property to PCIe controller model BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 09/14] ppc440: Remove ppc460ex_pcie_init legacy init function BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 10/14] ppc4xx_pci: Rename QOM type name define BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 11/14] ppc4xx_pci: Add define for ppc4xx-host-bridge type name BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 12/14] ppc440_pcix: Rename QOM type define abd move it to common header BALATON Zoltan
2023-07-05 20:12 ` [PATCH v2 13/14] ppc440_pcix: Don't use iomem for regs BALATON Zoltan
2023-07-05 20:28 ` Philippe Mathieu-Daudé
2023-07-05 20:12 ` [PATCH v2 14/14] ppc440_pcix: Stop using system io region for PCI bus BALATON Zoltan
2023-07-05 20:20 ` [PATCH v2 00/14] PPC440 devices misc clean up BALATON Zoltan
2023-07-06 0:48 ` Daniel Henrique Barboza
2023-07-06 1:09 ` BALATON Zoltan
2023-07-06 7:13 ` Daniel Henrique Barboza [this message]
2023-07-06 11:19 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00e7c46-6928-ed4d-f2c6-2754a590802f@gmail.com \
--to=danielhb413@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).