From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BCB4C54E67 for ; Wed, 20 Mar 2024 07:10:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmq5K-0005ft-KS; Wed, 20 Mar 2024 03:10:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmq5J-0005eg-DL for qemu-devel@nongnu.org; Wed, 20 Mar 2024 03:10:01 -0400 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmq5E-0007CW-GX for qemu-devel@nongnu.org; Wed, 20 Mar 2024 03:10:01 -0400 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so875383266b.0 for ; Wed, 20 Mar 2024 00:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710918594; x=1711523394; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9TCCyf82sNabPMIvnlMd5F1b2YXxnDB1L4NUWQP6dko=; b=vWht2AmmWQWMTQMEWwEClP/BkrqueULLfmVba//3b7ws2MNW5kCaC/OdBfT5VMx5YT WrP7k0wE0ZEL/Dzt9p4CPDDtUrYMpJqqsLvmbLMfHFeet2zcT+FLJHPRcNdwBMcMcI6m IhG35nrJhW0iOY3tA8cTeyuLBY0m6cVgDFpizLmW1C5AD/lDaTBD0rgvQahTqF+5ziZL uMK+NgLPZuwryu1kLFuLqPbN7y/JwNP31X1gppVOaUg9LKPyHBNco0LiJ+px4Xk3qZn2 dGCmoBQ9FJesR48Y5N8eoeX8gpBLYSGslnLy+1CapfBvYvaCfMyX3EZFKLjRPrnbL5HQ V5uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710918594; x=1711523394; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9TCCyf82sNabPMIvnlMd5F1b2YXxnDB1L4NUWQP6dko=; b=deTSBfFV+aU6xy6JZ0ade9BCnNVibsdufb9cbIvQhhB5zbl491TQgHAEmiSuIu36CM FfE40Aq5oOrA+r+j3LFyr6h60M8OzYF8higaT7i7gX047aJ5BIVD611mGrDgqdZKaDGQ 4YGybPBFxyfDaF/m17m1HMi8fr1847B3CV93sZmMpEFIVGXwSlNwMGbb3kKZ1zS+5YSI ZB/gZSY6mpwN7QLmZP/QwXCRUaPIZxm3fgJqCOFMkyUs3MIrejitIBTrEyM+bQIPC+WX U/0gIUAKK2XTNwGtp2X8ebIVgMNTuV+CQuL8/uW/tulsm53h9h4unqp5zf+aVGFdAibK bawQ== X-Forwarded-Encrypted: i=1; AJvYcCUayKliw9cIWqET8K9P97/6Cldy0pzpd5J+bkFxUAAkfPJoNqA33q0HSHbwPWLibLxINavj7RJA35vIG5ftZ/DSzJUsjI0= X-Gm-Message-State: AOJu0YyWQ5nNSd5MKpB+IjT9SsCbRrTxn6sTMM1Ubdjbl1BKDcBltUKp q3yMTC4YoskQ3xNpVO5iSgRLINNmg9wCC5NG51JCzeN+oxvZjN+xKfI6ubf5R+o= X-Google-Smtp-Source: AGHT+IEZ8OeADGhblWESXWeot/oliX8QkMaGHBZeusHIm3CsJABODaLeLw17BytWxWqWVi4hVgXl4g== X-Received: by 2002:a17:906:fcc6:b0:a46:2b87:9f38 with SMTP id qx6-20020a170906fcc600b00a462b879f38mr2718997ejb.29.1710918594489; Wed, 20 Mar 2024 00:09:54 -0700 (PDT) Received: from [192.168.69.100] ([176.176.156.105]) by smtp.gmail.com with ESMTPSA id st6-20020a170907c08600b00a46af639a77sm4151594ejc.172.2024.03.20.00.09.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 00:09:54 -0700 (PDT) Message-ID: Date: Wed, 20 Mar 2024 08:09:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-9.1 22/27] target/s390x: Convert to TCGCPUOps::get_cpu_state() Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Anton Johansson , Thomas Huth , David Hildenbrand , Ilya Leoshkevich References: <20240319154258.71206-1-philmd@linaro.org> <20240319154258.71206-23-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=philmd@linaro.org; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 19/3/24 22:05, Richard Henderson wrote: > On 3/19/24 05:42, Philippe Mathieu-Daudé wrote: >> Convert cpu_get_tb_cpu_state() to TCGCPUOps::get_cpu_state(). >> >> Note, now s390x_get_cpu_state() is restricted to TCG. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   target/s390x/cpu.h            | 30 ------------------------------ >>   target/s390x/s390x-internal.h |  2 ++ >>   target/s390x/cpu.c            |  1 + >>   target/s390x/tcg/mem_helper.c |  2 +- >>   target/s390x/tcg/translate.c  | 23 +++++++++++++++++++++++ >>   5 files changed, 27 insertions(+), 31 deletions(-) > > Why is the function in translate.c, not cpu.c (with or without ifdefs)? My understanding is target/foo/tcg/ is better for TCG-specific handlers, less #ifdef'ry and stubs. Then bar_helper.c are meant for TCG helpers (including "exec/helper-proto.h"). Can you think of a better file (new name?) in tcg/ or do you rather keep it in the main cpu.c? Thanks, Phil.