From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH] hw/core/qdev: Increase qdev_realize() kindness
Date: Sun, 5 Jul 2020 07:46:02 +0200 [thread overview]
Message-ID: <c0366cb5-fcb0-ff62-8ab5-92722a47d4e7@redhat.com> (raw)
In-Reply-To: <20200620153837.14222-1-f4bug@amsat.org>
On 20/06/20 17:38, Philippe Mathieu-Daudé wrote:
> - } else {
> - assert(!DEVICE_GET_CLASS(dev)->bus_type);
> + } else if (DEVICE_GET_CLASS(dev)->bus_type) {
> + error_report("%s: Unexpected bus '%s' for device '%s'",
> + __func__, DEVICE_GET_CLASS(dev)->bus_type,
> + object_get_typename(OBJECT(dev)));
> + abort();
> }
>
Since there is an errp, should we use it and be even kinder?
Paolo
next prev parent reply other threads:[~2020-07-05 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 15:38 [PATCH] hw/core/qdev: Increase qdev_realize() kindness Philippe Mathieu-Daudé
2020-07-04 16:47 ` Philippe Mathieu-Daudé
2020-07-05 5:46 ` Paolo Bonzini [this message]
2020-07-05 10:05 ` Philippe Mathieu-Daudé
2020-07-05 11:14 ` Paolo Bonzini
2020-07-05 11:59 ` Philippe Mathieu-Daudé
2020-07-06 6:48 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0366cb5-fcb0-ff62-8ab5-92722a47d4e7@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).