From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] tcg: Fold deposit with zero to and
Date: Thu, 17 Aug 2023 15:07:08 -0700 [thread overview]
Message-ID: <c03f11e3-847c-a792-51e0-16679485b43e@linaro.org> (raw)
In-Reply-To: <CAFEAcA9WUcJzrfQXnjM0Jw8CjaY6BW9hAKWGDRrMVU3BR2u6Vw@mail.gmail.com>
On 8/17/23 08:50, Peter Maydell wrote:
>> + if (arg_is_const(op->args[1])
>> + && arg_info(op->args[1])->val == 0
>> + && op->args[3] == 0) {
>> + uint64_t mask = MAKE_64BIT_MASK(0, op->args[4]);
>
> The docs for the TCG deposit op don't say what the restrictions on the
> immediate args are, but this will be UB for QEMU if args[4] is 0.
> Have we already sanitized those somewhere?
tcg_gen_deposit_{i32,i64} do so.
r~
next prev parent reply other threads:[~2023-08-17 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 14:55 [PATCH 0/3] tcg/i386: Improvements to deposit Richard Henderson
2023-08-16 14:55 ` [PATCH 1/3] tcg/i386: Drop BYTEH deposits for 64-bit Richard Henderson
2023-08-17 15:44 ` Peter Maydell
2023-08-17 22:04 ` Richard Henderson
2023-08-16 14:55 ` [PATCH 2/3] tcg: Fold deposit with zero to and Richard Henderson
2023-08-17 15:50 ` Peter Maydell
2023-08-17 22:07 ` Richard Henderson [this message]
2023-08-18 8:51 ` Peter Maydell
2023-08-21 12:05 ` Philippe Mathieu-Daudé
2023-08-16 14:55 ` [PATCH 3/3] tcg/i386: Allow immediate as input to deposit_* Richard Henderson
2023-08-17 15:55 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c03f11e3-847c-a792-51e0-16679485b43e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).