qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Ville Skyttä" <ville.skytta@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docs: Grammar and spelling fixes
Date: Mon, 11 Jun 2018 17:00:46 -0500	[thread overview]
Message-ID: <c04beb13-18f6-f5d9-6864-00206e7cbea0@redhat.com> (raw)
In-Reply-To: <20180611202532.2334-1-ville.skytta@iki.fi>

On 06/11/2018 03:25 PM, Ville Skyttä wrote:
> Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
> ---

> +++ b/docs/config/mach-virt-graphical.cfg
> @@ -185,7 +185,7 @@
>   # attached to it.
>   #
>   # We also create an optical disk, mostly for installation
> -# purposes: once the guest OS has been succesfully
> +# purposes: once the guest OS has been successfully

Looks like this line was copy-and-pasted a few times :)

> +++ b/docs/interop/qcow2.txt
> @@ -326,7 +326,7 @@ in the image file.
>   It contains pointers to the second level structures which are called refcount
>   blocks and are exactly one cluster in size.
>   
> -Given a offset into the image file, the refcount of its cluster can be obtained
> +Given an offset into the image file, the refcount of its cluster can be obtained
>   as follows:

This line is now long; it might be better if you reflow 'obtained', more 
like...

>   
>       refcount_block_entries = (cluster_size * 8 / refcount_bits)
> @@ -365,7 +365,7 @@ The L1 table has a variable size (stored in the header) and may use multiple
>   clusters, however it must be contiguous in the image file. L2 tables are
>   exactly one cluster in size.
>   
> -Given a offset into the virtual disk, the offset into the image file can be
> +Given an offset into the virtual disk, the offset into the image file can be
>   obtained as follows:

...this line.

With or without the reflow,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-06-11 22:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 20:25 [Qemu-devel] [PATCH] docs: Grammar and spelling fixes Ville Skyttä
2018-06-11 22:00 ` Eric Blake [this message]
2018-06-12  6:51   ` Ville Skyttä
  -- strict thread matches above, loose matches on Subject: below --
2018-06-12  6:51 Ville Skyttä
2018-06-12 12:11 ` Eric Blake
2018-06-14 16:49   ` Ville Skyttä
2018-06-18 21:46     ` Eric Blake
2018-06-14 19:14 ` Markus Armbruster
2018-07-13 10:34 ` Peter Maydell
2018-06-11 14:25 Ville Skyttä
2018-06-11 15:23 ` Peter Maydell
2018-06-11 20:25   ` Ville Skyttä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c04beb13-18f6-f5d9-6864-00206e7cbea0@redhat.com \
    --to=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ville.skytta@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).