From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A640C433E0 for ; Thu, 11 Mar 2021 22:05:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB67964F85 for ; Thu, 11 Mar 2021 22:05:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB67964F85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKTQt-0000P9-Sf for qemu-devel@archiver.kernel.org; Thu, 11 Mar 2021 17:05:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKTPk-0007oR-Cx for qemu-devel@nongnu.org; Thu, 11 Mar 2021 17:04:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKTPh-0005Tm-2J for qemu-devel@nongnu.org; Thu, 11 Mar 2021 17:04:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615500251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/8wmSEsNFf2s0GrRSOOCIkF27LJLhiH2Xr0IlBgUmmk=; b=da77rQUfXSfVi31FloyCEcu/k4EDVrC2/T0DN2ackFIpDtYXuK9jCyrJD6slVRfjbzwsM4 L+l7+7txKtfAX9yrcK4XpvkyBYbfp/W/DvFiIZQ2uoYcBaL1+AqWnudG9+PAE26NGICEUO 7oAU7QQ1hv6CjcPE6QzO5HiutErJFjQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-g-WZVZrANPOYX62pPibqfw-1; Thu, 11 Mar 2021 17:04:09 -0500 X-MC-Unique: g-WZVZrANPOYX62pPibqfw-1 Received: by mail-wm1-f70.google.com with SMTP id w10so2681399wmk.1 for ; Thu, 11 Mar 2021 14:04:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/8wmSEsNFf2s0GrRSOOCIkF27LJLhiH2Xr0IlBgUmmk=; b=LC90w0+QHdK9e6RFwNFRtdg8WP6P9XuZvEkqon5BK9zpNg6Q5k9BRRzmoNKMMnC2Ra 8nqQliomnuIQyZ6jg7cUfFu6hEdohAXaYhNKOP0VdL1oUctWgNpUqTT23dkGuc57wCm6 06g4k2z8KFrqp4kMZUo6Wfe23heNt/WnA8Q1dNMVaeNFj4U6tK6IF3+QKHFpvRDKHRPQ IaK1FLkZls8NZKSNIdYocwGtV3FlkLEnlirgyPw7wj7V7IVKQB3BSBzUDEs6o6Oh64P6 dFEvkLR1SlNoElgCa8gOozR850psaPqylcSAj/ltjXSgkg/7a5C7oJd0n8qKUL3DOaHF UrcQ== X-Gm-Message-State: AOAM533NeKIYvWQya9KsWBne61Tt2lVfwUIR7Eu53jqLntlSTAEbNTue 4p7NSyovlKigXDJlDO2L9ZenN65R7XQnIs4R9g7hYm7Y0VdMVy06VYZ/M90ZNomQN9iUGZJA7m1 k/Dr1FIi/vWEwlzw= X-Received: by 2002:a7b:c112:: with SMTP id w18mr9951456wmi.28.1615500248147; Thu, 11 Mar 2021 14:04:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUrIX3rqDRbQavtz/3YgbcEEvOhWk+CwacOhK/x+nwLWoduV9MSTiIBGDw9Itpjkt7f16u4A== X-Received: by 2002:a7b:c112:: with SMTP id w18mr9951427wmi.28.1615500247971; Thu, 11 Mar 2021 14:04:07 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id z2sm6519487wrm.0.2021.03.11.14.04.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 14:04:07 -0800 (PST) Subject: Re: [PATCH 05/14] migrate: remove QMP/HMP commands for speed, downtime and cache size To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20210224131142.1952027-1-berrange@redhat.com> <20210224131142.1952027-6-berrange@redhat.com> <1e211782-d0c6-6026-6a4e-b5eb626b8fb3@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 11 Mar 2021 23:04:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Michael S. Tsirkin" , libvir-list@redhat.com, Mark Cave-Ayland , qemu-devel@nongnu.org, Gerd Hoffmann , qemu-block@nongnu.org, Juan Quintela , Markus Armbruster , Wainer dos Santos Moschetta , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , "Dr. David Alan Gilbert" , Greg Kurz , Cleber Rosa , John Snow , David Gibson , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Max Reitz , qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/03/21 19:33, Daniel P. Berrangé wrote: > On Thu, Mar 11, 2021 at 07:18:54PM +0100, Paolo Bonzini wrote: >> On 11/03/21 12:54, Dr. David Alan Gilbert wrote: >>> * Daniel P. Berrangé (berrange@redhat.com) wrote: >>>> The generic 'migrate_set_parameters' command handle all types of param. >>>> >>>> Only the QMP commands were documented in the deprecations page, but the >>>> rationale for deprecating applies equally to HMP, and the replacements >>>> exist. Furthermore the HMP commands are just shims to the QMP commands, >>>> so removing the latter breaks the former unless they get re-implemented. >>>> >>>> Signed-off-by: Daniel P. Berrangé >>> >>> Yes OK; ouch that's going to break my 7 years of instinctive >>> 'migrate_set_speed 10G' typing, but it's probably the right thing to do. >> >> migrate_set_speed should remain if it is not changed to have a sane default. > > Define sane ? The default is 1 Gib/s since: > > commit 7590a2ae091fde8bb72d5df93977ab9707e23242 > Author: Laurent Vivier > Date: Mon Sep 21 16:49:57 2020 +0200 > > migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) Oh, I missed that! I was still thinking of the old 32 MiB/s value. Paolo