From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Fam Zheng" <famz@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] travis: display config.log when configure fails
Date: Tue, 12 Jun 2018 07:15:19 -0500 [thread overview]
Message-ID: <c076cfe0-47ac-1c54-a157-f3797bab807d@redhat.com> (raw)
In-Reply-To: <20180612082823.25507-1-berrange@redhat.com>
On 06/12/2018 03:28 AM, Daniel P. Berrangé wrote:
> When configure fails in CI systems we must be able to see the contents
> of the config.log file to diagnose the root cause.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .travis.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 814be151f4..fc9a1fe8a8 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -69,7 +69,7 @@ before_install:
> - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> - git submodule update --init --recursive
> before_script:
> - - ./configure ${CONFIG}
> + - ./configure ${CONFIG} || (cat config.log && exit 1)
If you want one less fork, you can spell this as:
- ./configure ${CONFIG} || { cat config.log && exit 1; }
Either way, the patch makes sense, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-12 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 8:28 [Qemu-devel] [PATCH] travis: display config.log when configure fails Daniel P. Berrangé
2018-06-12 8:43 ` Fam Zheng
2018-06-12 12:15 ` Eric Blake [this message]
2018-06-12 12:34 ` Philippe Mathieu-Daudé
2018-06-13 12:04 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c076cfe0-47ac-1c54-a157-f3797bab807d@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).