From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOvAU-0005NQ-Vr for qemu-devel@nongnu.org; Fri, 01 Jun 2018 21:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOvAU-0006Mq-7G for qemu-devel@nongnu.org; Fri, 01 Jun 2018 21:17:18 -0400 References: <20180417153945.20737-1-pbonzini@redhat.com> <20180417153945.20737-7-pbonzini@redhat.com> From: John Snow Message-ID: Date: Fri, 1 Jun 2018 21:17:12 -0400 MIME-Version: 1.0 In-Reply-To: <20180417153945.20737-7-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] ide: introduce ide_transfer_start_norecurse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org On 04/17/2018 11:39 AM, Paolo Bonzini wrote: > For the case where the end_transfer_func is also the caller of > ide_transfer_start, the mutual recursion can lead to unlimited > stack usage. Introduce a new version that can be used to change > tail recursion into a loop, and use it in trace_ide_atapi_cmd_reply_end. probably you mean ide_atapi_cmd_reply_end > > Signed-off-by: Paolo Bonzini Reviewed-by: John Snow