From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2C87C0015E for ; Fri, 14 Jul 2023 00:55:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK755-0008OH-8j; Thu, 13 Jul 2023 20:54:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK753-0008O9-K2 for qemu-devel@nongnu.org; Thu, 13 Jul 2023 20:54:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK752-000074-3P for qemu-devel@nongnu.org; Thu, 13 Jul 2023 20:54:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689296083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZF99bZwxHh+aYHFUkyiI0Ad/SC2kuV7B8NSvKw9bog=; b=fnRmxjmR948R0cCSkN41CK+AQr0xmcZb5AZG+ZTVj/ltqri1flfrv6mIi7TilYh4npRjtI LS0YamprehcCKx3NfOpeTD+aCWjgQFPXjeK/7fxvX83fG6UJZqVxkrqyWkRWJKGXgX2gEy rUe1yqf8aicUQlZ22IEVE2ANy3+RqpQ= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-jBbDx6mrOVCnUjUzPKYKKw-1; Thu, 13 Jul 2023 20:54:42 -0400 X-MC-Unique: jBbDx6mrOVCnUjUzPKYKKw-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5559caee9d3so1879804eaf.2 for ; Thu, 13 Jul 2023 17:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689296081; x=1691888081; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pZF99bZwxHh+aYHFUkyiI0Ad/SC2kuV7B8NSvKw9bog=; b=h8FsVhITkcpV4+uJAFyZRxauV9p2BL+8C2kaZbYVisXqqQTNqBd0KGqt2rohY9Z/CI jxTZZPllQrfGftrtmslEP/UvIfpOEqudIt69RMfEn4bkaeqzFP1R2XirX5ps/nLehrVy SVn8PGStWQyckrs85JgBFJKJ/YJWBjhC39LgPsaTV1UViEjQ20rrpc7V61Frg8ye7Uyv B2vfrGAbDR6ld7KtRtDliaaQpvMkDn9KDIJnurmZVlxKWsO2b6MxdDqW+ujWfEp9Kb7j qn4aluzPuCAH5rJEHydKx8BHqn2l8+1/HuiKW5eycjv0m81VbUOUa1FMWsMQyY1CyDCo O9Rg== X-Gm-Message-State: ABy/qLYOGWbcWzdWktMg8a7s7fWG2RMHJbiex6syJdYo3/EV8dQGTQ8U s8880nbX9UVpD5dOh55nbHvgJU60CQlaAFyyf0USnrmhJhNYZ+ZCjW0DwDFQtgv2Px71OHA9u6h k8zkPfG7DQ0lZJSI= X-Received: by 2002:a05:6358:9325:b0:134:c4dc:2c43 with SMTP id x37-20020a056358932500b00134c4dc2c43mr4206514rwa.28.1689296081392; Thu, 13 Jul 2023 17:54:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlE0T8/fo7LO61y9rHTzA3EYRLC4YTMi3M4eB4S12WTt/ij0WHHcMWtm04FeDbWaXakEenzxeQ== X-Received: by 2002:a05:6358:9325:b0:134:c4dc:2c43 with SMTP id x37-20020a056358932500b00134c4dc2c43mr4206481rwa.28.1689296080797; Thu, 13 Jul 2023 17:54:40 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id j7-20020a62e907000000b0067e985d2526sm6171136pfh.149.2023.07.13.17.54.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 17:54:40 -0700 (PDT) Message-ID: Date: Fri, 14 Jul 2023 10:54:31 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 0/3] hw/arm/virt: Use generic CPU invalidation Content-Language: en-US To: Richard Henderson , Marcin Juszkiewicz , Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com, eduardo@habkost.net, marcel.apfelbaum@gmail.com, philmd@linaro.org, wangyanan55@huawei.com, shan.gavin@gmail.com References: <20230713054502.410911-1-gshan@redhat.com> <2d21e89f-c965-e8f1-3705-dfea8367fc7e@linaro.org> <3a392615-5aca-f384-197f-84beb3086a29@redhat.com> <21752231-e869-033f-2a48-d5f06d001a48@linaro.org> From: Gavin Shan In-Reply-To: <21752231-e869-033f-2a48-d5f06d001a48@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.096, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Richard, On 7/14/23 05:27, Richard Henderson wrote: > On 7/13/23 13:34, Gavin Shan wrote: >> On 7/13/23 21:52, Marcin Juszkiewicz wrote: >>> W dniu 13.07.2023 o 13:44, Peter Maydell pisze: >>> >>>> I see this isn't a change in this patch, but given that >>>> what the user specifies is not "cortex-a8-arm-cpu" but >>>> "cortex-a8", why do we include the "-arm-cpu" suffix in >>>> the error messages? It's not valid syntax to say >>>> "-cpu cortex-a8-arm-cpu", so it's a bit misleading... >>> >>> Internally those cpu names are "max-{TYPE_ARM_CPU}" and similar for other architectures. >>> >>> I like the change but it (IMHO) needs to cut "-{TYPE_*_CPU}" string from names: >>> >>> 13:37 marcin@applejack:qemu$ ./build/aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-r5 >>> qemu-system-aarch64: Invalid CPU type: cortex-r5-arm-cpu >>> The valid types are: cortex-a7-arm-cpu, cortex-a15-arm-cpu, cortex-a35-arm-cpu, cortex-a55-arm-cpu, cortex-a72-arm-cpu, cortex-a76-arm-cpu, a64fx-arm-cpu, neoverse-n1-arm-cpu, neoverse-v1-arm-cpu, cortex-a53-arm-cpu, cortex-a57-arm-cpu, host-arm-cpu, max-arm-cpu >>> >>> 13:37 marcin@applejack:qemu$ ./build/aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57-arm-cpu >>> qemu-system-aarch64: unable to find CPU model 'cortex-a57-arm-cpu' >>> >> >> The suffix of CPU types are provided in hw/arm/virt.c::valid_cpu_types in PATCH[2]. >> In the generic validation, the complete CPU type is used. The error message also >> have complete CPU type there. >> >> Peter and Marcin, how about to split the CPU types to two fields, as below? In this >> way, the complete CPU type will be used for validation and the 'internal' names will >> be used for the error messages. >> >> struct MachineClass { >>      const char *valid_cpu_type_suffix; >>      const char **valid_cpu_types; > > While you're changing this: > > const char * const *valid_cpu_types; > yes, will do. >> }; >> >> hw/arm/virt.c >> ------------- >> >> static const char *valid_cpu_types[] = { > > So that you can then do > > static const char * const valid_cpu_types[] > yes, will do. Thanks, Gavin