From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-4.0] usb: move ehci_create_ich9_with_companions to hw/i386
Date: Mon, 10 Dec 2018 18:37:21 +0100 [thread overview]
Message-ID: <c082c4ad-7eba-b234-110e-2e6b45c0c92d@redhat.com> (raw)
In-Reply-To: <20181210131726.erol3faahqvrtelm@sirius.home.kraxel.org>
On 10/12/18 14:17, Gerd Hoffmann wrote:
> On Fri, Nov 30, 2018 at 10:45:12PM +0100, Paolo Bonzini wrote:
>> This function is only needed when Q35 is in use. Moving it to
>> the same file that uses it lets you disable the entire USB
>> subsystem in x86_64-softmmu.mak; of course doing that will
>> cause -usb to break horribly, but one thing at a time.
>
> Patch doesn't apply.
>
>> - if (0 && machine_usb(machine)) {
>> + if (machine_usb(machine)) {
>
> Leftover local debug change here?
Yes, more precisely this patch replaced the quick "0 &&" hack.
Paolo
prev parent reply other threads:[~2018-12-10 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 21:45 [Qemu-devel] [PATCH for-4.0] usb: move ehci_create_ich9_with_companions to hw/i386 Paolo Bonzini
2018-12-01 19:00 ` Philippe Mathieu-Daudé
2018-12-10 13:17 ` Gerd Hoffmann
2018-12-10 17:37 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c082c4ad-7eba-b234-110e-2e6b45c0c92d@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).