Re: [Qemu-devel] [PATCH v3] iotests: Add test for dataplane mirroring

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On 2017-09-29 19:33, Eric Blake wrote:
> On 09/29/2017 12:08 PM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> v3: Make the test actually pass (the reference output from v2 only
>>     worked with v1 of the test...)
>> ---
>>  tests/qemu-iotests/127     | 97 ++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/127.out | 14 +++++++
>>  tests/qemu-iotests/group   |  1 +
>>  3 files changed, 112 insertions(+)
>>  create mode 100755 tests/qemu-iotests/127
>>  create mode 100644 tests/qemu-iotests/127.out
>>
> 
>> +_cleanup()
>> +{
>> +    _cleanup_qemu
>> +    _cleanup_test_img
>> +    _rm_test_img "$TEST_IMG.overlay0"
>> +    _rm_test_img "$TEST_IMG.overlay1"
>> +}
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
> 
> Semantic conflict with Jeff's patches for './check -s' to preserve
> intermediate files.  Otherwise,
> Reviewed-by: Eric Blake <eblake@redhat.com>

True, but as long as v4 of his series is not around, I feel OK to put
the burden of having to rebase on him. :-)

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]