From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/7] block: Use 'detect-zeroes' option for 'blockdev-change-medium'
Date: Wed, 21 Sep 2016 14:19:02 -0500 [thread overview]
Message-ID: <c08ddb1d-38db-0d97-7b8c-eb8f1ab94f1d@redhat.com> (raw)
In-Reply-To: <1474405737-2092-6-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On 09/20/2016 04:08 PM, Kevin Wolf wrote:
> Instead of modifying the new BDS after it has been opened, use the newly
> supported 'detect-zeroes' option in bdrv_open_common() so that all
> requirements are checked (detect-zeroes=unmap requires discard=unmap).
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/block-backend.c | 9 ++++-----
> blockdev.c | 9 ++++++---
> include/sysemu/block-backend.h | 2 +-
> 3 files changed, 11 insertions(+), 9 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-21 19:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 21:08 [Qemu-devel] [PATCH 0/7] block: Make more blockdev-add options work Kevin Wolf
2016-09-20 21:08 ` [Qemu-devel] [PATCH 1/7] block: Drop aio/cache consistency check from qmp_blockdev_add() Kevin Wolf
2016-09-20 22:15 ` Eric Blake
2016-09-20 21:08 ` [Qemu-devel] [PATCH 2/7] block/qapi: Use separate options type for curl driver Kevin Wolf
2016-09-20 22:18 ` Eric Blake
2016-09-20 21:08 ` [Qemu-devel] [PATCH 3/7] block/qapi: Move 'aio' option to file driver Kevin Wolf
2016-09-20 22:27 ` Eric Blake
2016-09-22 10:25 ` Kevin Wolf
2016-09-22 13:18 ` Eric Blake
2016-09-20 21:08 ` [Qemu-devel] [PATCH 4/7] block: Parse 'detect-zeroes' in bdrv_open_common() Kevin Wolf
2016-09-21 19:16 ` Eric Blake
2016-09-20 21:08 ` [Qemu-devel] [PATCH 5/7] block: Use 'detect-zeroes' option for 'blockdev-change-medium' Kevin Wolf
2016-09-21 19:19 ` Eric Blake [this message]
2016-09-20 21:08 ` [Qemu-devel] [PATCH 6/7] block: Move 'discard' option to bdrv_open_common() Kevin Wolf
2016-09-21 19:22 ` Eric Blake
2016-09-20 21:08 ` [Qemu-devel] [PATCH 7/7] block: Remove qemu_root_bds_opts Kevin Wolf
2016-09-21 19:23 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c08ddb1d-38db-0d97-7b8c-eb8f1ab94f1d@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).