From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check
Date: Thu, 15 Feb 2018 11:10:40 +0100 [thread overview]
Message-ID: <c0b33436-0ec6-fe3c-ea5c-ac9bba0fb692@redhat.com> (raw)
In-Reply-To: <20180215104953.1fa574ba.cohuck@redhat.com>
On 15.02.2018 10:49, Cornelia Huck wrote:
> On Thu, 15 Feb 2018 10:47:45 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> On 14.02.2018 20:04, Richard Henderson wrote:
>>> On 02/14/2018 09:31 AM, David Hildenbrand wrote:
>>>> Let's add proper alignment checks for a handful of instructions that
>>>> require a SPECIFICATION exception in case alignment is violated.
>>>>
>>>> Introduce new wout/in functions. Declare them as "static inline" to avoid
>>>> warnings about not being used for CONFIG_USER_ONLY (as we are right
>>>> now only using them for privileged instructions).
>>>
>>> Annoyingly, clang will still warn for this.
>>>
>>
>> Hm, so the only solution is to add nasty idfefs then :(
>
> Yup, very annoying indeed, but probably the only way to shut clang up...
>
Will resend soon!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-02-15 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 17:31 [Qemu-devel] [PATCH v2] s390x/tcg: add various alignment check David Hildenbrand
2018-02-14 19:04 ` Richard Henderson
2018-02-15 9:47 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-02-15 9:49 ` Cornelia Huck
2018-02-15 10:10 ` David Hildenbrand [this message]
2018-02-15 14:13 ` Eric Blake
2018-02-15 14:19 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0b33436-0ec6-fe3c-ea5c-ac9bba0fb692@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).