From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 05/12] tcg/mips: Split out tcg_out_movi_one
Date: Tue, 11 Apr 2023 14:34:19 +0200 [thread overview]
Message-ID: <c0b5e268-080a-4262-84f4-e4a5f849bdfb@linaro.org> (raw)
In-Reply-To: <20230408030359.3368868-6-richard.henderson@linaro.org>
On 8/4/23 05:03, Richard Henderson wrote:
> Emit all constants that can be loaded in exactly one insn.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/mips/tcg-target.c.inc | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/tcg/mips/tcg-target.c.inc b/tcg/mips/tcg-target.c.inc
> index c2f8d6550b..f0ae418ba6 100644
> --- a/tcg/mips/tcg-target.c.inc
> +++ b/tcg/mips/tcg-target.c.inc
> @@ -514,20 +514,34 @@ static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)
> return true;
> }
>
> +static bool tcg_out_movi_one(TCGContext *s, TCGReg ret, tcg_target_long arg)
> +{
> + if (arg == (int16_t)arg) {
> + tcg_out_opc_imm(s, OPC_ADDIU, ret, TCG_REG_ZERO, arg);
> + return true;
> + }
> + if (arg == (uint16_t)arg) {
> + tcg_out_opc_imm(s, OPC_ORI, ret, TCG_REG_ZERO, arg);
> + return true;
> + }
> + if (arg == (int32_t)arg && (arg & 0xffff) == 0) {
> + tcg_out_opc_imm(s, OPC_LUI, ret, TCG_REG_ZERO, arg >> 16);
> + return true;
> + }
> + return false;
> +}
> +
> static void tcg_out_movi(TCGContext *s, TCGType type,
> TCGReg ret, tcg_target_long arg)
> {
> if (TCG_TARGET_REG_BITS == 64 && type == TCG_TYPE_I32) {
> arg = (int32_t)arg;
> }
> - if (arg == (int16_t)arg) {
> - tcg_out_opc_imm(s, OPC_ADDIU, ret, TCG_REG_ZERO, arg);
> - return;
> - }
> - if (arg == (uint16_t)arg) {
> - tcg_out_opc_imm(s, OPC_ORI, ret, TCG_REG_ZERO, arg);
> +
> + if (tcg_out_movi_one(s, ret, arg)) {
> return;
> }
> +
> if (TCG_TARGET_REG_BITS == 32 || arg == (int32_t)arg) {
> tcg_out_opc_imm(s, OPC_LUI, ret, TCG_REG_ZERO, arg >> 16);
Shouldn't this block be removed in this patch?
> } else {
next prev parent reply other threads:[~2023-04-11 12:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 3:03 [PATCH for-8.1 00/12] tcg/mips: Backend improvements Richard Henderson
2023-04-08 3:03 ` [PATCH 01/12] tcg/mips: Move TCG_AREG0 to S8 Richard Henderson
2023-04-08 3:03 ` [PATCH 02/12] tcg/mips: Move TCG_GUEST_BASE_REG to S7 Richard Henderson
2023-04-08 3:03 ` [PATCH 03/12] tcg/mips: Unify TCG_GUEST_BASE_REG tests Richard Henderson
2023-04-08 3:03 ` [PATCH 04/12] tcg/mips: Create and use TCG_REG_TB Richard Henderson
2023-04-08 3:03 ` [PATCH 05/12] tcg/mips: Split out tcg_out_movi_one Richard Henderson
2023-04-11 12:29 ` Philippe Mathieu-Daudé
2023-04-11 12:34 ` Philippe Mathieu-Daudé [this message]
2023-04-12 6:55 ` Richard Henderson
2023-04-08 3:03 ` [PATCH 06/12] tcg/mips: Split out tcg_out_movi_two Richard Henderson
2023-04-08 3:03 ` [PATCH 07/12] tcg/mips: Use the constant pool for 64-bit constants Richard Henderson
2023-04-08 3:03 ` [PATCH 08/12] tcg/mips: Aggressively use the constant pool for n64 calls Richard Henderson
2023-04-08 3:03 ` [PATCH 09/12] tcg/mips: Try tb-relative addresses in tcg_out_movi Richard Henderson
2023-04-08 3:03 ` [PATCH 10/12] tcg/mips: Try three insns with shift and add " Richard Henderson
2023-04-08 3:03 ` [PATCH 11/12] tcg/mips: Use qemu_build_not_reached for LO/HI_OFF Richard Henderson
2023-04-08 3:03 ` [PATCH 12/12] tcg/mips: Replace MIPS_BE with HOST_BIG_ENDIAN Richard Henderson
2023-04-11 12:26 ` Philippe Mathieu-Daudé
2023-05-10 10:24 ` [PATCH for-8.1 00/12] tcg/mips: Backend improvements Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0b5e268-080a-4262-84f4-e4a5f849bdfb@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).