Re: [PULL 11/41] hw/acpi/ghes: Make ghes_record_cper_errors() static

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi Mauro,

On 6/3/25 23:36, Mauro Carvalho Chehab wrote:
> Em Wed,  5 Mar 2025 02:21:26 +0100
> Philippe Mathieu-Daudé <philmd@linaro.org> escreveu:
> 
>> From: Gavin Shan <gshan@redhat.com>
>>
>> acpi_ghes_memory_errors() is the only caller, no need to expose
>> the function. Besides, the last 'return' in this function isn't
>> necessary and remove it.
>>
>> No functional changes intended.
> 
> Please revert this patch, as ghes_record_cper_errors() was written
> to be used for error injection. As agreed last year with some ACPI
> maintainers, we ended splitting the error injection series on two parts
> to make easier for people to review it.
> 
> The followup series:
> 
> 	https://lore.kernel.org/qemu-devel/cover.1740903110.git.mchehab+huawei@kernel.org/
> 
> Need this function to be not static, as this will be used by a
> QMP caller.
> 
> The usage itself is on this patch:
> 
> 	https://lore.kernel.org/qemu-devel/6ef8d6a3f42e3347ed6fd3d1fc29ab5ff2a070df.1740903110.git.mchehab+huawei@kernel.org/
> 
> but this one causes conflict since patch 01 of the series.

As of this commit this method isn't used elsewhere in the tree,
so the reversion has to happen in the series using it, if it
eventually lands. Otherwise it is too costly to maintain
incomplete features.

Regards,

Phil.