From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Harsh Prateek Bora <harshpb@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Greg Kurz" <groug@kaod.org>, "Anton Johansson" <anjo@rev.ng>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-ppc@nongnu.org
Subject: Re: [RFC PATCH 3/4] accel/tcg: Guard tb_flush() with tcg_enabled() and remove the stub
Date: Fri, 15 Sep 2023 17:42:56 +0200 [thread overview]
Message-ID: <c0d4266f-b11d-8ac2-f23a-5609f08a0678@linaro.org> (raw)
In-Reply-To: <ce35def0-318f-91ac-592f-517bb5bce09b@linux.ibm.com>
On 15/9/23 17:25, Harsh Prateek Bora wrote:
>
>
> On 9/15/23 01:22, Philippe Mathieu-Daudé wrote:
>> The check on tcg_enabled() make it clearer we want
>> this call under TCG.
>>
>
> tb_flush already has a check for tcg_enabled() in its definition.
> Do we really need to check for same before calling it?
Good point, I didn't notice. I'll replace the call in
tb_flush() by an assertion.
>
> Thanks
> Harsh
>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> accel/stubs/tcg-stub.c | 4 ----
>> cpu.c | 15 +++++++++------
>> gdbstub/softmmu.c | 5 ++++-
>> hw/ppc/spapr_hcall.c | 2 +-
>> 4 files changed, 14 insertions(+), 12 deletions(-)
next prev parent reply other threads:[~2023-09-15 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 19:52 [PATCH 0/4] accel/tcg: Stubs cleanups Philippe Mathieu-Daudé
2023-09-14 19:52 ` [PATCH 1/4] accel/tcg: Remove tlb_set_dirty() stub Philippe Mathieu-Daudé
2023-09-15 14:06 ` Harsh Prateek Bora
2023-09-14 19:52 ` [PATCH 2/4] accel/tcg: Remove unused tcg_flush_jmp_cache() stub Philippe Mathieu-Daudé
2023-09-15 15:12 ` Harsh Prateek Bora
2023-09-15 15:41 ` Philippe Mathieu-Daudé
2023-09-14 19:52 ` [RFC PATCH 3/4] accel/tcg: Guard tb_flush() with tcg_enabled() and remove the stub Philippe Mathieu-Daudé
2023-09-15 15:25 ` Harsh Prateek Bora
2023-09-15 15:42 ` Philippe Mathieu-Daudé [this message]
2023-09-19 6:52 ` Harsh Prateek Bora
2023-09-14 19:52 ` [RFC PATCH 4/4] accel/tcg: Keep tlb_set_dirty() internal Philippe Mathieu-Daudé
2023-09-15 15:27 ` Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d4266f-b11d-8ac2-f23a-5609f08a0678@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=anjo@rev.ng \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=harshpb@linux.ibm.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).