From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eric Blake <eblake@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, Michael Hanselmann <hansmi@vshn.ch>,
Michael Hanselmann <public@hansmi.ch>
Subject: Re: [Qemu-devel] [PATCH for-3.1 2/2] usb-mtp: outlaw slashes in filenames
Date: Sat, 1 Dec 2018 12:55:33 +0100 [thread overview]
Message-ID: <c0da7ecd-4929-e64c-347d-a80b5368a47d@redhat.com> (raw)
In-Reply-To: <bfce1b7d-6b41-0296-605e-e63ed359d249@redhat.com>
On 30/11/18 20:58, Eric Blake wrote:
> On 11/30/18 1:08 PM, Philippe Mathieu-Daudé wrote:
>> On 30/11/18 12:12, Gerd Hoffmann wrote:
>>> Slash is unix directory separator, so they are not allowed in filenames.
>>> Note this also stops the classic escape via "../".
>>>
>>> Fixes: CVE-2018-16867
>>> Reported-by: Michael Hanselmann (hansmi.ch)
>>
>> It's common for scripts to match '<email>', can you write this one as
>> Michael Hanselmann <hansmi.ch>?
>
> That's not an email address, though. Do we have an email for Michael, or
> just a username?
>
I did not notice hehe :)
Per the gpg key: Michael Hanselmann <public@hansmi.ch>
Per git commits: Michael Hanselmann <hansmi@vshn.ch>
Cc'ed him so he can decide/confirm.
next prev parent reply other threads:[~2018-12-01 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 11:12 [Qemu-devel] [PATCH for-3.1 0/2] usb-mtp: two bugfixes (one security fix) Gerd Hoffmann
2018-11-30 11:12 ` [Qemu-devel] [PATCH for-3.1 1/2] usb-mtp: fix utf16_to_str Gerd Hoffmann
2018-11-30 13:13 ` Markus Armbruster
2018-11-30 19:58 ` Bandan Das
2018-11-30 11:12 ` [Qemu-devel] [PATCH for-3.1 2/2] usb-mtp: outlaw slashes in filenames Gerd Hoffmann
2018-11-30 19:08 ` Philippe Mathieu-Daudé
2018-11-30 19:58 ` Eric Blake
2018-12-01 11:55 ` Philippe Mathieu-Daudé [this message]
2018-12-01 13:49 ` Michael Hanselmann
2018-11-30 20:08 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0da7ecd-4929-e64c-347d-a80b5368a47d@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=hansmi@vshn.ch \
--cc=kraxel@redhat.com \
--cc=public@hansmi.ch \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).