From: John Snow <jsnow@redhat.com>
To: kuhn.chenqun@huawei.com, qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 01/13] block/stream: Remove redundant statement in stream_run()
Date: Tue, 25 Feb 2020 16:49:35 -0500 [thread overview]
Message-ID: <c0f26ff5-fee8-aa5a-a245-24f610be1ed0@redhat.com> (raw)
In-Reply-To: <20200225020937.25028-2-kuhn.chenqun@huawei.com>
On 2/24/20 9:09 PM, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> Clang static code analyzer show warning:
> block/stream.c:186:9: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> Cc: John Snow <jsnow@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: qemu-block@nongnu.org
> ---
> block/stream.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/stream.c b/block/stream.c
> index 5562ccbf57..d78074ac80 100644
> --- a/block/stream.c
> +++ b/block/stream.c
> @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp)
> break;
> }
> }
> - ret = 0;
>
> /* Publish progress */
> job_progress_update(&s->common.job, n);
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2020-02-25 21:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 2:09 [PATCH 00/13]redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
2020-02-25 2:09 ` [PATCH 01/13] block/stream: Remove redundant statement in stream_run() kuhn.chenqun
2020-02-25 21:49 ` John Snow [this message]
2020-02-25 2:09 ` [PATCH 02/13] block/iscsi:Remove redundant statement in iscsi_open() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
2020-02-25 9:36 ` Philippe Mathieu-Daudé
2020-02-25 10:01 ` Chenqun (kuhn)
2020-02-25 10:11 ` Philippe Mathieu-Daudé
2020-02-25 10:25 ` Chenqun (kuhn)
2020-02-25 2:09 ` [PATCH 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() kuhn.chenqun
2020-02-25 2:09 ` [PATCH 12/13] usb/hcd-ehci: Remove redundant statements kuhn.chenqun
2020-02-25 9:38 ` Philippe Mathieu-Daudé
2020-02-25 2:09 ` [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() kuhn.chenqun
2020-02-25 9:44 ` Philippe Mathieu-Daudé
2020-02-25 10:12 ` Chenqun (kuhn)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f26ff5-fee8-aa5a-a245-24f610be1ed0@redhat.com \
--to=jsnow@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).