From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>, Qemu Developers <qemu-devel@nongnu.org>
Cc: Li Qiang <liqiang6-s@360.cn>,
Peter Maydell <peter.maydell@linaro.org>,
Huawei PSIRT <PSIRT@huawei.com>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH v2] scsi: esp: check TI buffer index before read/write
Date: Mon, 6 Jun 2016 14:00:03 +0200 [thread overview]
Message-ID: <c0f4e9fb-d194-fecb-c5e7-3634b19a6cf6@redhat.com> (raw)
In-Reply-To: <1464694581-31596-1-git-send-email-ppandit@redhat.com>
On 31/05/2016 13:36, P J P wrote:
> + if ((s->rregs[ESP_RSTAT] & STAT_PIO_MASK) == 0) {
> + /* Data out. */
> + qemu_log_mask(LOG_UNIMP, "esp: PIO data read not implemented\n");
> + s->rregs[ESP_FIFO] = 0;
> + esp_raise_irq(s);
> + } else if (s->ti_rptr < s->ti_wptr) {
> s->ti_size--;
> - if ((s->rregs[ESP_RSTAT] & STAT_PIO_MASK) == 0) {
> - /* Data out. */
> - qemu_log_mask(LOG_UNIMP,
> - "esp: PIO data read not implemented\n");
> - s->rregs[ESP_FIFO] = 0;
> - } else {
> - s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++];
> - }
> + s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++];
> esp_raise_irq(s);
> }
> if (s->ti_size == 0) {
Shouldn't this become a "s->ti_rptr == s->ti_wptr" too?
Thanks,
Paolo
next prev parent reply other threads:[~2016-06-06 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:36 [Qemu-devel] [PATCH v2] scsi: esp: check TI buffer index before read/write P J P
2016-06-06 11:48 ` P J P
2016-06-06 12:00 ` Paolo Bonzini [this message]
2016-06-06 12:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f4e9fb-d194-fecb-c5e7-3634b19a6cf6@redhat.com \
--to=pbonzini@redhat.com \
--cc=PSIRT@huawei.com \
--cc=liqiang6-s@360.cn \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).