From: Richard Henderson <richard.henderson@linaro.org>
To: Tomoaki Kawada <i@yvt.jp>, qemu-devel@nongnu.org
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] target/rx: update PC correctly in wait instruction
Date: Thu, 21 Apr 2022 10:10:40 -0700 [thread overview]
Message-ID: <c11ce181-04a9-627f-d2f8-77b040e5d1e9@linaro.org> (raw)
In-Reply-To: <20220417060224.2131788-1-i@yvt.jp>
On 4/16/22 23:02, Tomoaki Kawada wrote:
> `cpu_pc` at this point does not necessary point to the current
> instruction (i.e., the wait instruction being translated), so it's
> incorrect to calculate the new value of `cpu_pc` based on this. It must
> be updated with `ctx->base.pc_next`, which contains the correct address
> of the next instruction.
>
> This change fixes the wait instruction skipping the subsequent branch
> when used in an idle loop like this:
>
> 0: wait
> bra.b 0b
> brk // should be unreachable
>
> Signed-off-by: Tomoaki Kawada <i@yvt.jp>
Queued to target-rx-next.
r~
prev parent reply other threads:[~2022-04-21 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 6:02 [PATCH] target/rx: update PC correctly in wait instruction Tomoaki Kawada
2022-04-17 16:06 ` Richard Henderson
2022-04-18 13:18 ` Yoshinori Sato
2022-04-21 17:10 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c11ce181-04a9-627f-d2f8-77b040e5d1e9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=i@yvt.jp \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).