qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-trivial@nongnu.org
Subject: Re: [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it
Date: Mon, 5 Jun 2023 11:48:32 +0200	[thread overview]
Message-ID: <c1227ef3-259d-0855-f02c-7d62dd574072@redhat.com> (raw)
In-Reply-To: <a6fc91db-a4e3-e9b7-ee51-d07cd4982f02@redhat.com>

On 6/5/23 11:05, Paolo Bonzini wrote:
> 
>> On 05/06/2023 10.27, Paolo Bonzini wrote:
>>> Queued, thanks.
>>
>> Please unqueue it again, I'm still seeing some issues with the patch 
>> (not sure why yet):
>>
>> https://gitlab.com/thuth/qemu/-/jobs/4411089009
> 
> Yeah, noticed that myself now. 😄

I think all you need is:

diff --git a/meson.build b/meson.build
index 025523f2065..3ec35c96fea 100644
--- a/meson.build
+++ b/meson.build
@@ -1345,7 +1345,7 @@ if sdl.found()
                       #include <SDL.h>
                       #include <SDL_syswm.h>
                       int main(int argc, char *argv[]) { return 0; }
-                     ''', dependencies: sdl, args: '-Wundef')
+                     ''', dependencies: sdl, args: ['-Wundef', '-Werror'])
      sdl = declare_dependency(compile_args: '-Wno-undef',
                               dependencies: sdl,
                               version: sdl.version())

Paolo



  reply	other threads:[~2023-06-05  9:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 16:34 [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it Thomas Huth
2023-06-03  3:30 ` Richard Henderson
2023-06-05  7:46 ` Thomas Huth
2023-06-05  8:27 ` Paolo Bonzini
2023-06-05  8:47   ` Thomas Huth
2023-06-05  9:05     ` Paolo Bonzini
2023-06-05  9:48       ` Paolo Bonzini [this message]
2023-06-05  8:53 ` Daniel P. Berrangé
2023-06-05  8:58   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1227ef3-259d-0855-f02c-7d62dd574072@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).