* [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef
@ 2018-02-16 17:31 Dr. David Alan Gilbert (git)
2018-02-16 17:47 ` Philippe Mathieu-Daudé
2018-02-16 18:38 ` Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2018-02-16 17:31 UTC (permalink / raw)
To: qemu-devel, mark.cave-ayland
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
RHEL6's compilers don't like the repeated typedef.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
include/hw/misc/macio/cuda.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/misc/macio/cuda.h b/include/hw/misc/macio/cuda.h
index 6afbdd13ee..494b709579 100644
--- a/include/hw/misc/macio/cuda.h
+++ b/include/hw/misc/macio/cuda.h
@@ -93,12 +93,12 @@ typedef struct CUDAState {
} CUDAState;
/* MOS6522 CUDA */
-typedef struct MOS6522CUDAState {
+struct MOS6522CUDAState {
/*< private >*/
MOS6522State parent_obj;
CUDAState *cuda;
-} MOS6522CUDAState;
+};
#define TYPE_MOS6522_CUDA "mos6522-cuda"
#define MOS6522_CUDA(obj) OBJECT_CHECK(MOS6522CUDAState, (obj), \
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef
2018-02-16 17:31 [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef Dr. David Alan Gilbert (git)
@ 2018-02-16 17:47 ` Philippe Mathieu-Daudé
2018-02-16 18:38 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-02-16 17:47 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, mark.cave-ayland
On 02/16/2018 02:31 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> RHEL6's compilers don't like the repeated typedef.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/misc/macio/cuda.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/misc/macio/cuda.h b/include/hw/misc/macio/cuda.h
> index 6afbdd13ee..494b709579 100644
> --- a/include/hw/misc/macio/cuda.h
> +++ b/include/hw/misc/macio/cuda.h
> @@ -93,12 +93,12 @@ typedef struct CUDAState {
> } CUDAState;
>
> /* MOS6522 CUDA */
> -typedef struct MOS6522CUDAState {
> +struct MOS6522CUDAState {
> /*< private >*/
> MOS6522State parent_obj;
>
> CUDAState *cuda;
> -} MOS6522CUDAState;
> +};
>
> #define TYPE_MOS6522_CUDA "mos6522-cuda"
> #define MOS6522_CUDA(obj) OBJECT_CHECK(MOS6522CUDAState, (obj), \
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef
2018-02-16 17:31 [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef Dr. David Alan Gilbert (git)
2018-02-16 17:47 ` Philippe Mathieu-Daudé
@ 2018-02-16 18:38 ` Peter Maydell
2018-02-17 15:00 ` Mark Cave-Ayland
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2018-02-16 18:38 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: QEMU Developers, Mark Cave-Ayland
On 16 February 2018 at 17:31, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> RHEL6's compilers don't like the repeated typedef.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> include/hw/misc/macio/cuda.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/misc/macio/cuda.h b/include/hw/misc/macio/cuda.h
> index 6afbdd13ee..494b709579 100644
> --- a/include/hw/misc/macio/cuda.h
> +++ b/include/hw/misc/macio/cuda.h
> @@ -93,12 +93,12 @@ typedef struct CUDAState {
> } CUDAState;
>
> /* MOS6522 CUDA */
> -typedef struct MOS6522CUDAState {
> +struct MOS6522CUDAState {
> /*< private >*/
> MOS6522State parent_obj;
>
> CUDAState *cuda;
> -} MOS6522CUDAState;
> +};
>
> #define TYPE_MOS6522_CUDA "mos6522-cuda"
> #define MOS6522_CUDA(obj) OBJECT_CHECK(MOS6522CUDAState, (obj), \
> --
Thanks; applied to master as a buildfix.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef
2018-02-16 18:38 ` Peter Maydell
@ 2018-02-17 15:00 ` Mark Cave-Ayland
0 siblings, 0 replies; 4+ messages in thread
From: Mark Cave-Ayland @ 2018-02-17 15:00 UTC (permalink / raw)
To: Peter Maydell, Dr. David Alan Gilbert (git); +Cc: QEMU Developers
On 16/02/18 18:38, Peter Maydell wrote:
> On 16 February 2018 at 17:31, Dr. David Alan Gilbert (git)
> <dgilbert@redhat.com> wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> RHEL6's compilers don't like the repeated typedef.
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>> include/hw/misc/macio/cuda.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/hw/misc/macio/cuda.h b/include/hw/misc/macio/cuda.h
>> index 6afbdd13ee..494b709579 100644
>> --- a/include/hw/misc/macio/cuda.h
>> +++ b/include/hw/misc/macio/cuda.h
>> @@ -93,12 +93,12 @@ typedef struct CUDAState {
>> } CUDAState;
>>
>> /* MOS6522 CUDA */
>> -typedef struct MOS6522CUDAState {
>> +struct MOS6522CUDAState {
>> /*< private >*/
>> MOS6522State parent_obj;
>>
>> CUDAState *cuda;
>> -} MOS6522CUDAState;
>> +};
>>
>> #define TYPE_MOS6522_CUDA "mos6522-cuda"
>> #define MOS6522_CUDA(obj) OBJECT_CHECK(MOS6522CUDAState, (obj), \
>> --
>
> Thanks; applied to master as a buildfix.
Thanks both. Apologies I got caught up later than expected yesterday.
ATB,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-17 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-16 17:31 [Qemu-devel] [PATCH] cuda.h: Fix multiple typedef Dr. David Alan Gilbert (git)
2018-02-16 17:47 ` Philippe Mathieu-Daudé
2018-02-16 18:38 ` Peter Maydell
2018-02-17 15:00 ` Mark Cave-Ayland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).