From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] hexagon: do not specify Python scripts as inputs
Date: Wed, 10 Mar 2021 11:56:04 +0100 [thread overview]
Message-ID: <c143c927-1ad8-2564-0230-22b05331e53b@redhat.com> (raw)
In-Reply-To: <20210310104937.253532-2-pbonzini@redhat.com>
On 3/10/21 11:49 AM, Paolo Bonzini wrote:
> Python scripts are not inputs, and putting them in @INPUT@. This
> puts requirements on the command line format, keeping all inputs
> close to the name of the script. Avoid that by not including the
> script in the command and not in the inputs.
>
> Also wrap "PYTHONPATH" usage with "env", since setting the environment
> this way is not valid under Windows.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/hexagon/meson.build | 30 ++++++++++--------------------
> 1 file changed, 10 insertions(+), 20 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-03-10 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 10:49 [PATCH 0/4] Upgrade Meson to 0.57.x Paolo Bonzini
2021-03-10 10:49 ` [PATCH 1/4] hexagon: do not specify Python scripts as inputs Paolo Bonzini
2021-03-10 10:56 ` Philippe Mathieu-Daudé [this message]
2021-03-11 13:11 ` Richard Henderson
2021-03-11 17:47 ` Paolo Bonzini
2021-03-10 10:49 ` [PATCH 2/4] meson: bump submodule to 0.57.1 Paolo Bonzini
2021-03-10 10:49 ` [PATCH 3/4] meson: switch minimum meson version to 0.57.0 Paolo Bonzini
2021-03-10 10:49 ` [PATCH 4/4] hexagon: use env keyword argument to pass PYTHONPATH Paolo Bonzini
2021-03-11 13:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c143c927-1ad8-2564-0230-22b05331e53b@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).