From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qemu -netdev tun/tap support can't handle macvtap type devices
Date: Thu, 8 Dec 2016 09:52:07 +0800 [thread overview]
Message-ID: <c1475981-5d6f-a623-525c-fa72b101a96b@redhat.com> (raw)
In-Reply-To: <CAFEAcA-riLzPyfT+CSbEgLzRoJiGVRByk7Ft7EdDqhVcOH4vHg@mail.gmail.com>
On 2016年12月07日 22:32, Peter Maydell wrote:
> On 7 December 2016 at 14:24, Daniel P. Berrange <berrange@redhat.com> wrote:
>> On Wed, Dec 07, 2016 at 02:21:24PM +0000, Peter Maydell wrote:
>>> On 7 December 2016 at 14:07, Daniel P. Berrange <berrange@redhat.com> wrote:
>>>> On Wed, Dec 07, 2016 at 12:30:31PM +0000, Peter Maydell wrote:
>>>>> On 7 December 2016 at 12:04, Daniel P. Berrange <berrange@redhat.com> wrote:
>>>>>> note 'fds' plural, instead of 'fd'
>>>>> What's the difference between that and the "usual suggested workaround"
>>>>> I described above that doesn't work with queues=... ?
>>>> It just seems the 'queues' param always wants you to use 'fds' instead
>>>> of 'fd' - 'fds' takes a comma-separated list of FDs - one per queue
>>>> and 'fd' only takes a single FD.
>>> Oh, I see. That seems a bit obscure :-)
>> And pointless, because QemuOpts would have allowed use of 'fd' multiple
>> times instead of inventing a new arg. fd=1,fd=3,fd=6 could have worked
>> fine with multi-queue :-(
> I guess the best we could do now would be to make fd= and fds= synonyms
> with both supporting either comma-separated or being specified
> multiple times ?
When multiqueue were introduced, qemu does not support such kind of
parameters. This maybe useful (or use fd[0],fd[1]), but I'm not sure
this is really needed consider libvirt is in charge of doing such things
now.
>
> It's particularly confusing in this case that fd= doesn't work with
> queues=, because the user isn't trying to pass multiple fds, just
> the one is fine.
Since fd can only accept on file descriptor, so it implies 1 queue. For
"fds", specifying queues seems redundant, since qemu can count the #fds
by itself.
Thanks
>
> thanks
> -- PMM
>
next prev parent reply other threads:[~2016-12-08 1:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 12:01 [Qemu-devel] qemu -netdev tun/tap support can't handle macvtap type devices Peter Maydell
2016-12-07 12:04 ` Daniel P. Berrange
2016-12-07 12:30 ` Peter Maydell
2016-12-07 14:07 ` Daniel P. Berrange
2016-12-07 14:21 ` Peter Maydell
2016-12-07 14:24 ` Daniel P. Berrange
2016-12-07 14:32 ` Peter Maydell
2016-12-08 1:52 ` Jason Wang [this message]
2016-12-08 15:37 ` Peter Maydell
2016-12-08 1:53 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1475981-5d6f-a623-525c-fa72b101a96b@redhat.com \
--to=jasowang@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).