From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
linux-kernel@vger.kernel.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v2 01/15] acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED
Date: Tue, 1 Oct 2024 09:03:38 +0200 [thread overview]
Message-ID: <c1514e6bc32eb9bb407ebc94e3dbcea4da5a5438.1727766088.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1727766088.git.mchehab+huawei@kernel.org>
This is just duplicating ACPI_GHES_ERROR_SOURCE_COUNT, which
has a better name. So, drop the duplication.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
hw/acpi/ghes.c | 7 ++-----
include/hw/acpi/ghes.h | 3 ++-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index e9511d9b8f71..dc217694deb9 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -34,9 +34,6 @@
/* The max size in bytes for one error block */
#define ACPI_GHES_MAX_RAW_DATA_LENGTH (1 * KiB)
-/* Now only support ARMv8 SEA notification type error source */
-#define ACPI_GHES_ERROR_SOURCE_COUNT 1
-
/* Generic Hardware Error Source version 2 */
#define ACPI_GHES_SOURCE_GENERIC_ERROR_V2 10
@@ -396,7 +393,7 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address)
AcpiGedState *acpi_ged_state;
AcpiGhesState *ags;
- assert(source_id < ACPI_HEST_SRC_ID_RESERVED);
+ assert(source_id < ACPI_GHES_ERROR_SOURCE_COUNT);
acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED,
NULL));
@@ -407,7 +404,7 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address)
if (physical_address) {
- if (source_id < ACPI_HEST_SRC_ID_RESERVED) {
+ if (source_id < ACPI_GHES_ERROR_SOURCE_COUNT) {
start_addr += source_id * sizeof(uint64_t);
}
diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h
index 674f6958e905..59e3b8fb24b9 100644
--- a/include/hw/acpi/ghes.h
+++ b/include/hw/acpi/ghes.h
@@ -59,7 +59,8 @@ enum AcpiGhesNotifyType {
enum {
ACPI_HEST_SRC_ID_SEA = 0,
/* future ids go here */
- ACPI_HEST_SRC_ID_RESERVED,
+
+ ACPI_GHES_ERROR_SOURCE_COUNT
};
typedef struct AcpiGhesState {
--
2.46.0
next prev parent reply other threads:[~2024-10-01 14:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 7:03 [PATCH v2 00/15] Prepare GHES driver to support error injection Mauro Carvalho Chehab
2024-10-01 7:03 ` Mauro Carvalho Chehab [this message]
2024-10-01 7:03 ` [PATCH v2 02/15] acpi/ghes: simplify acpi_ghes_record_errors() code Mauro Carvalho Chehab
2024-10-01 7:03 ` [PATCH v2 03/15] acpi/ghes: simplify the per-arch caller to build HEST table Mauro Carvalho Chehab
2024-10-02 13:30 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 04/15] acpi/ghes: better handle source_id and notification Mauro Carvalho Chehab
2024-10-02 13:28 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 05/15] acpi/ghes: Fix acpi_ghes_record_errors() argument Mauro Carvalho Chehab
2024-10-02 13:21 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 06/15] acpi/ghes: Remove a duplicated out of bounds check Mauro Carvalho Chehab
2024-10-01 7:03 ` [PATCH v2 07/15] acpi/ghes: Change the type for source_id Mauro Carvalho Chehab
2024-10-02 12:27 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 08/15] acpi/ghes: Prepare to support multiple sources on ghes Mauro Carvalho Chehab
2024-10-02 12:57 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 09/15] acpi/ghes: make the GHES record generation more generic Mauro Carvalho Chehab
2024-10-02 13:14 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 10/15] acpi/ghes: move offset calculus to a separate function Mauro Carvalho Chehab
2024-10-02 13:20 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 11/15] acpi/ghes: better name GHES memory error function Mauro Carvalho Chehab
2024-10-01 7:03 ` [PATCH v2 12/15] acpi/ghes: don't crash QEMU if ghes GED is not found Mauro Carvalho Chehab
2024-10-02 12:46 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 13/15] acpi/ghes: rename etc/hardware_error file macros Mauro Carvalho Chehab
2024-10-01 7:03 ` [PATCH v2 14/15] acpi/ghes: better name the offset of the hardware error firmware Mauro Carvalho Chehab
2024-10-02 12:38 ` Igor Mammedov
2024-10-01 7:03 ` [PATCH v2 15/15] docs: acpi_hest_ghes: fix documentation for CPER size Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1514e6bc32eb9bb407ebc94e3dbcea4da5a5438.1727766088.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=gengdongjiu1@gmail.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).