From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csYAX-0002ti-Ed for qemu-devel@nongnu.org; Mon, 27 Mar 2017 13:11:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csYAS-0001N9-7u for qemu-devel@nongnu.org; Mon, 27 Mar 2017 13:11:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60280) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csYAR-0001MK-Uv for qemu-devel@nongnu.org; Mon, 27 Mar 2017 13:10:56 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB17B85363 for ; Mon, 27 Mar 2017 17:10:54 +0000 (UTC) References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: Date: Mon, 27 Mar 2017 12:10:52 -0500 MIME-Version: 1.0 In-Reply-To: <1490621195-2228-10-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WNLVD54RGdPigH5orRvWqnfr8CLahIEk3" Subject: Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: jdurgin@redhat.com, jcody@redhat.com, kwolf@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WNLVD54RGdPigH5orRvWqnfr8CLahIEk3 From: Eric Blake To: Markus Armbruster , qemu-devel@nongnu.org Cc: jdurgin@redhat.com, jcody@redhat.com, kwolf@redhat.com, mreitz@redhat.com Message-ID: Subject: Re: [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> In-Reply-To: <1490621195-2228-10-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/27/2017 08:26 AM, Markus Armbruster wrote: > This reverts a part of commit 8a47e8e. We're having second thoughts > on the QAPI schema (and thus the external interface), and haven't > reached consensus, yet. Issues include: >=20 > * BlockdevOptionsRbd member @password-secret isn't actually a > password, it's a key generated by Ceph. >=20 > * We're not sure where member @password-secret belongs (see the > previous commit). >=20 > * How @password-secret interacts with settings from a configuration > file specified with @conf is undocumented. I suspect it's untested, > too. >=20 > Let's avoid painting ourselves into a corner now, and revert the > feature for 2.9. >=20 > Note that users can still configure an authentication key with a > configuration file. They probably do that anyway if they use Ceph > outside QEMU as well. >=20 > Signed-off-by: Markus Armbruster > --- > qapi/block-core.json | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Eric Blake This time, it's fairly obvious that you aren't affecting -drive usage. >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 6a7ca0b..2e60ab5 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2618,9 +2618,6 @@ > # @server: Monitor host address and port. This maps > # to the "mon_host" Ceph option. > # > -# @password-secret: The ID of a QCryptoSecret object providing > -# the password for the login. > -# > # Since: 2.9 > ## > { 'struct': 'BlockdevOptionsRbd', >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WNLVD54RGdPigH5orRvWqnfr8CLahIEk3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJY2UedAAoJEKeha0olJ0Nq1J0IAJAEJKn8l9mkYnpNp845XlgR KV04sl+ktFjjjjfVMSbtmVvjLZ1ioQwa61VgAMxgABxBkPNAwhMRrkHCLYUTLvD3 OYGjE6ehsQcs0ZJZikBK8E90ldzScoglX+b01Kty6ikXZtUUvLjHv+OSNn2UmYPw D4ODZNTumVeQoSunOKesNcH2jLH1Q6VHuYdlT1/zbPTPFKAsdeG5thnSI0au1dyI WbrbOUMiT9Emw9YmDTjuKOx6gRaLiFt0FyfA93qcAPAXv2BQr8QtKF6cGIK4KnYm Qztj4ULEC5xtWZVO0GAdigX3NSrhu1RAUo+CgWULm4i5ThtU15HdL+q+2nYElnY= =fU0U -----END PGP SIGNATURE----- --WNLVD54RGdPigH5orRvWqnfr8CLahIEk3--