From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Li Qiang <liq3ea@gmail.com>,
keith.busch@intel.com, kwolf@redhat.com, mreitz@redhat.com
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/3] nvme: use TYPE_NVME instead of constant string
Date: Mon, 14 Jan 2019 12:08:24 +0100 [thread overview]
Message-ID: <c166eb4e-eb85-8e6d-c0ee-32ad74e40031@redhat.com> (raw)
In-Reply-To: <20190111020849.22674-2-liq3ea@gmail.com>
On 1/11/19 3:08 AM, Li Qiang wrote:
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 7c8c63e8f5..f206391e8e 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1381,7 +1381,7 @@ static void nvme_instance_init(Object *obj)
> }
>
> static const TypeInfo nvme_info = {
> - .name = "nvme",
> + .name = TYPE_NVME,
> .parent = TYPE_PCI_DEVICE,
> .instance_size = sizeof(NvmeCtrl),
> .class_init = nvme_class_init,
>
next prev parent reply other threads:[~2019-01-14 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 2:08 [Qemu-devel] [PATCH v2 0/3] nvme small fix Li Qiang
2019-01-11 2:08 ` [Qemu-devel] [PATCH v2 1/3] nvme: use TYPE_NVME instead of constant string Li Qiang
2019-01-14 11:08 ` Philippe Mathieu-Daudé [this message]
2019-01-11 2:08 ` [Qemu-devel] [PATCH v2 2/3] nvme: ensure the num_queues is not zero Li Qiang
2019-01-14 11:15 ` Philippe Mathieu-Daudé
2019-01-11 2:08 ` [Qemu-devel] [PATCH v2 3/3] nvme: use pci_dev directly in nvme_realize Li Qiang
2019-01-14 11:16 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c166eb4e-eb85-8e6d-c0ee-32ad74e40031@redhat.com \
--to=philmd@redhat.com \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=liq3ea@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).