From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, beata.michalska@linaro.org
Subject: Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes
Date: Wed, 10 Jul 2019 12:22:12 +0200 [thread overview]
Message-ID: <c167f496-57c3-1e90-82fd-109b68be1d23@redhat.com> (raw)
In-Reply-To: <20190709184823.4135-1-richard.henderson@linaro.org>
On 7/9/19 8:48 PM, Richard Henderson wrote:
> The aarch64 argument ordering for the operands is big-endian,
> whereas the tcg argument ordering is little-endian. Use REG0
> so that we honor the rZ constraints.
>
> Fixes: 464c2969d5d
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/aarch64/tcg-target.inc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
> index b0f8106642..0713448bf5 100644
> --- a/tcg/aarch64/tcg-target.inc.c
> +++ b/tcg/aarch64/tcg-target.inc.c
> @@ -2226,7 +2226,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
>
> case INDEX_op_extract2_i64:
> case INDEX_op_extract2_i32:
> - tcg_out_extr(s, ext, a0, a1, a2, args[3]);
> + tcg_out_extr(s, ext, a0, REG0(2), REG0(1), args[3]);
> break;
>
> case INDEX_op_add2_i32:
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-10 10:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 18:48 [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes Richard Henderson
2019-07-10 9:22 ` Aleksandar Markovic
2019-07-10 9:48 ` Richard Henderson
2019-07-10 10:04 ` Aleksandar Markovic
2019-07-10 15:40 ` Peter Maydell
2019-07-10 17:28 ` Aleksandar Markovic
2019-07-10 10:22 ` Philippe Mathieu-Daudé [this message]
2019-07-10 10:42 ` Alex Bennée
2019-07-10 18:12 ` Aleksandar Markovic
2019-07-11 11:45 ` Richard Henderson
2019-07-11 17:06 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c167f496-57c3-1e90-82fd-109b68be1d23@redhat.com \
--to=philmd@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).