From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D5FC73C7C for ; Wed, 10 Jul 2019 10:23:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB4CF20651 for ; Wed, 10 Jul 2019 10:23:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB4CF20651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl9kp-0008NJ-3H for qemu-devel@archiver.kernel.org; Wed, 10 Jul 2019 06:23:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40272) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl9k0-0007Nd-PB for qemu-devel@nongnu.org; Wed, 10 Jul 2019 06:22:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hl9jy-00048Q-QA for qemu-devel@nongnu.org; Wed, 10 Jul 2019 06:22:24 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40076) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hl9jx-0003uE-HV for qemu-devel@nongnu.org; Wed, 10 Jul 2019 06:22:22 -0400 Received: by mail-wm1-f66.google.com with SMTP id v19so1663703wmj.5 for ; Wed, 10 Jul 2019 03:22:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ll2mQ9aZWRQ4mMGTvnZvalGdQmmyD4heGZJ1CmBKXfI=; b=F5+WteRhx50IAlafAOtt3VhcZDZBxkGHK+fPF9DqgOJSTb9GZ5bgkJdqZ6yONaLCNT XNS0qA4LxB/EGseEVLi5U6fdr1iU5JsfZXg8z7SLh3ORzn7qofZ0h1qBnhwj+2v3N7LA QOzCotXbVk9/tqIKeaqBx/UKrhc/ezhFP0OCsqPGd28Frk89YgzF/wJ7ntvYRlSREmjx 6Jl63wF/aCeLJhJVwIA6XGHwbfaBYCxQrUDH6j8gmh/wiflnPVMMYePBWNKnIpG+vpwv em+HsSPdmwEFc43CELT1k+4NLKqw3mf4Lu3waw5PDxvRkZkZXwMgT7YTx5Ur07Ikeqd+ BHeQ== X-Gm-Message-State: APjAAAVsBMeiZ6Vzq4KDwX+P2e2KWIs9kKkKQXgjczLhzraFUjtRZevr lX6o4J1AsIW485xC4CuXga3F5w== X-Google-Smtp-Source: APXvYqwU8rRdyJIg/6Mk5bruqdn4qNupI14mt+nEmI17jDGqHImpmOqnAZ2010/GkRXaOvaW219dYw== X-Received: by 2002:a1c:7a02:: with SMTP id v2mr4673976wmc.159.1562754134549; Wed, 10 Jul 2019 03:22:14 -0700 (PDT) Received: from [10.32.224.100] (red-hat-inc.vlan560.asr1.mad1.gblx.net. [159.63.51.90]) by smtp.gmail.com with ESMTPSA id r5sm1944106wmh.35.2019.07.10.03.22.13 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2019 03:22:13 -0700 (PDT) To: Richard Henderson , qemu-devel@nongnu.org References: <20190709184823.4135-1-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Wed, 10 Jul 2019 12:22:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190709184823.4135-1-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.66 Subject: Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, beata.michalska@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/9/19 8:48 PM, Richard Henderson wrote: > The aarch64 argument ordering for the operands is big-endian, > whereas the tcg argument ordering is little-endian. Use REG0 > so that we honor the rZ constraints. > > Fixes: 464c2969d5d > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.inc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c > index b0f8106642..0713448bf5 100644 > --- a/tcg/aarch64/tcg-target.inc.c > +++ b/tcg/aarch64/tcg-target.inc.c > @@ -2226,7 +2226,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, > > case INDEX_op_extract2_i64: > case INDEX_op_extract2_i32: > - tcg_out_extr(s, ext, a0, a1, a2, args[3]); > + tcg_out_extr(s, ext, a0, REG0(2), REG0(1), args[3]); > break; > > case INDEX_op_add2_i32: > Reviewed-by: Philippe Mathieu-Daudé