From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Tweak error message related to qemu-img convert
Date: Mon, 22 May 2017 15:40:06 +0200 [thread overview]
Message-ID: <c16a9700-10fb-2ebf-75b2-739528670439@redhat.com> (raw)
In-Reply-To: <ed7c0d92-94de-820f-bb80-000d8c6c9e6e@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On 2017-05-20 00:07, Eric Blake wrote:
> On 05/19/2017 08:30 AM, Max Reitz wrote:
>> On 2017-05-08 19:13, Eric Blake wrote:
>>> When converting a 1.1 image down to 0.10, qemu-iotests 060 forces
>>> a contrived failure where allocating a cluster used to replace a
>>> zero cluster reads unaligned data. Since it is a zero cluster
>>> rather than a data cluster being converted, changing the error
>>> message to match our earlier change in 'qcow2: Make distinction
>>> bewteen zero cluster types obvious' is worthwhile.
>
> I really had problems with that commit message. If you want to re-stage,
> you could s/bewteen/between/
Sure, can do (and done :-)).
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
prev parent reply other threads:[~2017-05-22 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 17:13 [Qemu-devel] [PATCH] block: Tweak error message related to qemu-img convert Eric Blake
2017-05-08 18:41 ` Max Reitz
2017-05-08 19:06 ` Eric Blake
2017-05-08 19:09 ` Max Reitz
2017-05-19 13:30 ` Max Reitz
2017-05-19 22:07 ` Eric Blake
2017-05-22 13:40 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c16a9700-10fb-2ebf-75b2-739528670439@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).