Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

On 5/21/19 3:12 AM, Wei Yang wrote:
> All the python script in scripts/qapi is used to generate qapi code. Use
> wildcard to simplify it.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>  Makefile | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)

I'm not a fan of $(wildcard). It makes your tarball creation
non-deterministic - if there is a leftover file from development that is
no longer part of the build, wildcard will still pick it up.  Explicit
lists are better.  I'm inclined to NACK this, but Markus has final say
since he maintains the qapi generator.

> 
> diff --git a/Makefile b/Makefile
> index 155f066a20..38b74782d9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -541,13 +541,7 @@ qemu-ga$(EXESUF): QEMU_CFLAGS += -I qga/qapi-generated
>  qemu-keymap$(EXESUF): LIBS += $(XKBCOMMON_LIBS)
>  qemu-keymap$(EXESUF): QEMU_CFLAGS += $(XKBCOMMON_CFLAGS)
>  
> -qapi-py = $(SRC_PATH)/scripts/qapi/commands.py \
> -$(SRC_PATH)/scripts/qapi/events.py \
> -$(SRC_PATH)/scripts/qapi/introspect.py \
> -$(SRC_PATH)/scripts/qapi/types.py \
> -$(SRC_PATH)/scripts/qapi/visit.py \
> -$(SRC_PATH)/scripts/qapi/common.py \
> -$(SRC_PATH)/scripts/qapi/doc.py \
> +qapi-py = $(wildcard $(SRC_PATH)/scripts/qapi/*.py) \
>  $(SRC_PATH)/scripts/qapi-gen.py
>  
>  qga/qapi-generated/qga-qapi-types.c qga/qapi-generated/qga-qapi-types.h \
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]