From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95C8C43613 for ; Mon, 24 Jun 2019 13:23:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D1FC212F5 for ; Mon, 24 Jun 2019 13:23:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D1FC212F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfOwg-0007k8-P5 for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 09:23:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36083) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfOw0-0006lq-NC for qemu-devel@nongnu.org; Mon, 24 Jun 2019 09:23:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfOvy-0005Io-OR for qemu-devel@nongnu.org; Mon, 24 Jun 2019 09:23:00 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38804) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfOvw-0005Fz-Qi for qemu-devel@nongnu.org; Mon, 24 Jun 2019 09:22:57 -0400 Received: by mail-wr1-f65.google.com with SMTP id d18so13915055wrs.5 for ; Mon, 24 Jun 2019 06:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IxC5K3hKa9tC3R9rtfu9sMpXSzuWl/8E7PGxgNeSKhk=; b=YdqK9ra7qxqeW4ejZmJSs0mZ3XiI96oB151Z8PHcRvtF62Coq+X8knaI3zMiviS0Rh P8oCSFh7UUdlKewdLe6n2ngLEw+ERa/aYSkgQd9R6i5b+0O//XlNeW2UzylIxaMnp8S1 29wBCsOgPuRnMUuD3H4Q93BZ/oCquN9guZrzX+gXV6bDfhBwWQKpWFY2DwMRQHWBFeFw 7v89QCAbaNGd3n25qbz0NxAcCJv6QT1+bHCypPi2fribaCADKiMGxT7pe31cqx6aT77G 6VTQ1EKn8tNVVyIaVRb9iUdG+VZ1ME3wEhZtSAHkga2HlfI+XDdc1PiA8HlQqpv5fhDy W+3Q== X-Gm-Message-State: APjAAAWTPVERuVo7XDuNcQ1uA4/cxQqVnbw/d+852mhFFbHTqEqfXbRu aYxod7Vw903RpG8QxeEvXTmYMg== X-Google-Smtp-Source: APXvYqwOW2FsjQkoFWKzWCGodDlMXmiJ2+sJ1oLOHfVQD84hwmB7kknvHHtRpf5wk3ICMz3j7Z6TCg== X-Received: by 2002:a05:6000:1203:: with SMTP id e3mr44585489wrx.300.1561382574920; Mon, 24 Jun 2019 06:22:54 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:7822:aa18:a9d8:39ab? ([2001:b07:6468:f312:7822:aa18:a9d8:39ab]) by smtp.gmail.com with ESMTPSA id r5sm23973230wrg.10.2019.06.24.06.22.53 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 06:22:54 -0700 (PDT) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , peter.maydell@linaro.org References: <20190624123835.28869-1-alex.bennee@linaro.org> From: Paolo Bonzini Message-ID: Date: Mon, 24 Jun 2019 15:22:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190624123835.28869-1-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.65 Subject: Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vitaly Kuznetsov , Richard Henderson , qemu-devel@nongnu.org, Eduardo Habkost , Roman Kagan Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/06/19 14:38, Alex Bennée wrote: > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduces a > feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in > hyperv-stub to do the same feature check as in the real hyperv.c > > Signed-off-by: Alex Bennée > Cc: Vitaly Kuznetsov > Cc: Paolo Bonzini > Cc: Roman Kagan > --- > target/i386/hyperv-stub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c > index fe548cbae2..0028527e79 100644 > --- a/target/i386/hyperv-stub.c > +++ b/target/i386/hyperv-stub.c > @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit) > { > switch (exit->type) { > case KVM_EXIT_HYPERV_SYNIC: > - if (!cpu->hyperv_synic) { > + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) { > return -1; > } > > Queued, thanks. Paolo