From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH 1/2] pci: Remove unused pci_get_*_by_mask() functions
Date: Tue, 26 Jul 2022 15:27:02 -0700 [thread overview]
Message-ID: <c1a3e96d-a5d7-ffc2-d91a-ad42cee2ef1f@linaro.org> (raw)
In-Reply-To: <20220726163206.1780707-2-peter.maydell@linaro.org>
On 7/26/22 09:32, Peter Maydell wrote:
> The helper functions pci_get_{byte,word,long,quad}_by_mask()
> were added in 2012 in commit c9f50cea70a1596. In the decade
> since we have never added a single use of them.
>
> The helpers clearly aren't that helpful, so drop them
> rather than carrying around dead code.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> include/hw/pci/pci.h | 28 ----------------------------
> 1 file changed, 28 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-07-26 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 16:32 [PATCH 0/2] pci *_by_mask() coverity fix Peter Maydell
2022-07-26 16:32 ` [PATCH 1/2] pci: Remove unused pci_get_*_by_mask() functions Peter Maydell
2022-07-26 22:27 ` Richard Henderson [this message]
2022-07-26 16:32 ` [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask() Peter Maydell
2022-07-26 21:29 ` Philippe Mathieu-Daudé via
2022-07-26 22:30 ` Richard Henderson
2022-07-27 10:26 ` Peter Maydell
2022-08-17 10:48 ` Michael S. Tsirkin
2022-08-17 12:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1a3e96d-a5d7-ffc2-d91a-ad42cee2ef1f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).