qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] accel: Remove unused AccelClass::available field
Date: Tue, 23 Apr 2019 00:20:35 +0200	[thread overview]
Message-ID: <c1aa85de-849d-fe69-2059-244c2bb3e197@redhat.com> (raw)
In-Reply-To: <20190422210448.2488-4-ehabkost@redhat.com>

On 4/22/19 11:04 PM, Eduardo Habkost wrote:
> The field is not used anymore, we can remove it.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
mingw64:
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  include/sysemu/accel.h | 1 -
>  accel/accel.c          | 5 -----
>  2 files changed, 6 deletions(-)
> 
> diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h
> index 5565e00a96..70e9e2f2a1 100644
> --- a/include/sysemu/accel.h
> +++ b/include/sysemu/accel.h
> @@ -38,7 +38,6 @@ typedef struct AccelClass {
>  
>      const char *opt_name;
>      const char *name;
> -    int (*available)(void);
>      int (*init_machine)(MachineState *ms);
>      void (*setup_post)(MachineState *ms, AccelState *accel);
>      bool *allowed;
> diff --git a/accel/accel.c b/accel/accel.c
> index 454fef9d92..5fa31717b4 100644
> --- a/accel/accel.c
> +++ b/accel/accel.c
> @@ -107,11 +107,6 @@ void configure_accelerator(MachineState *ms, const char *progname)
>          if (!acc) {
>              continue;
>          }
> -        if (acc->available && !acc->available()) {
> -            printf("%s not supported for this target\n",
> -                   acc->name);
> -            continue;
> -        }
>          ret = accel_init_machine(acc, ms);
>          if (ret < 0) {
>              init_failed = true;
> 

  parent reply	other threads:[~2019-04-22 22:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 21:04 [Qemu-devel] [PATCH 0/3] Remove AccelClass::available field Eduardo Habkost
2019-04-22 21:04 ` Eduardo Habkost
2019-04-22 21:04 ` [Qemu-devel] [PATCH 1/3] qtest: Move accel code to accel/qtest.c Eduardo Habkost
2019-04-22 21:04   ` Eduardo Habkost
2019-04-22 21:56   ` Philippe Mathieu-Daudé
2019-04-22 21:56     ` Philippe Mathieu-Daudé
2019-04-22 22:08     ` Eduardo Habkost
2019-04-22 22:08       ` Eduardo Habkost
2019-04-22 22:17       ` Philippe Mathieu-Daudé
2019-04-22 22:17         ` Philippe Mathieu-Daudé
2019-04-23  5:07   ` Thomas Huth
2019-04-23  5:07     ` Thomas Huth
2019-04-23 11:08     ` [Qemu-devel] [PATCH] fixup! " Eduardo Habkost
2019-04-23 11:08       ` Eduardo Habkost
2019-04-23 11:29       ` Thomas Huth
2019-04-23 11:29         ` Thomas Huth
2019-04-22 21:04 ` [Qemu-devel] [PATCH 2/3] qtest: Don't compile qtest accel on non-POSIX systems Eduardo Habkost
2019-04-22 21:04   ` Eduardo Habkost
2019-04-22 22:20   ` Philippe Mathieu-Daudé
2019-04-22 22:20     ` Philippe Mathieu-Daudé
2019-04-23  5:09   ` Thomas Huth
2019-04-23  5:09     ` Thomas Huth
2019-04-22 21:04 ` [Qemu-devel] [PATCH 3/3] accel: Remove unused AccelClass::available field Eduardo Habkost
2019-04-22 21:04   ` Eduardo Habkost
2019-04-22 22:20   ` Philippe Mathieu-Daudé [this message]
2019-04-22 22:20     ` Philippe Mathieu-Daudé
2019-04-23  5:09   ` Thomas Huth
2019-04-23  5:09     ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1aa85de-849d-fe69-2059-244c2bb3e197@redhat.com \
    --to=philmd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).