From: Richard Henderson <richard.henderson@linaro.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: "Kyle Evans" <kevans@freebsd.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
f4bug@amsat.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Sean Bruno" <sbruno@FreeBSD.org>,
"Juergen Lock" <nox@jelal.kn-bremen.de>,
"Raphael Kubo da Costa" <rakuco@FreeBSD.org>,
"Stacey Son" <sson@FreeBSD.org>
Subject: Re: [PATCH v3 06/11] bsd-user: Helper routines h2g_old_sysctl
Date: Fri, 17 Feb 2023 07:41:08 -1000 [thread overview]
Message-ID: <c1b0959b-4af7-a432-4391-e57d26a81894@linaro.org> (raw)
In-Reply-To: <20230216233353.13944-7-imp@bsdimp.com>
On 2/16/23 13:33, Warner Losh wrote:
> h2g_old_sysctl does the byte swapping in the data to return it to the
> target for the 'well known' types. For most of the types, either the
> data is returned verbatim (strings, byte size, opaque we don't know
> about) or it's returned with byte swapping (for all the integer
> types). However, for ABI32 targets, LONG and ULONG are different sizes,
> and need to be carefully converted (along with help from the caller).
>
> Co-Authored-by: Sean Bruno<sbruno@FreeBSD.org>
> Signed-off-by: Sean Bruno<sbruno@FreeBSD.org>
> Co-Authored-by: Juergen Lock<nox@jelal.kn-bremen.de>
> Signed-off-by: Juergen Lock<nox@jelal.kn-bremen.de>
> Co-Authored-by: Raphael Kubo da Costa<rakuco@FreeBSD.org>
> Signed-off-by: Raphael Kubo da Costa<rakuco@FreeBSD.org>
> Co-Authored-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
> bsd-user/freebsd/os-sys.c | 100 ++++++++++++++++++++++++++++++++++++--
> 1 file changed, 96 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> + }
> + else {
> +#ifdef TARGET_ABI32
} else {
r~
next prev parent reply other threads:[~2023-02-17 17:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 23:33 [PATCH v3 00/11] 2023 Q1 bsd-user upstreaming: bugfixes and sysctl Warner Losh
2023-02-16 23:33 ` [PATCH v3 01/11] bsd-user: Don't truncate the return value from freebsd_syscall Warner Losh
2023-02-16 23:33 ` [PATCH v3 02/11] build: Don't specify -no-pie for --static user-mode programs Warner Losh
2023-02-17 0:38 ` Alex Bennée
2023-02-16 23:33 ` [PATCH v3 03/11] bsd-user: Add sysarch syscall Warner Losh
2023-02-16 23:33 ` [PATCH v3 04/11] bsd-user: various helper routines for sysctl Warner Losh
2023-02-17 17:38 ` Richard Henderson
2023-02-16 23:33 ` [PATCH v3 05/11] bsd-user: Helper routines oidfmt Warner Losh
2023-02-16 23:33 ` [PATCH v3 06/11] bsd-user: Helper routines h2g_old_sysctl Warner Losh
2023-02-17 17:41 ` Richard Henderson [this message]
2023-02-16 23:33 ` [PATCH v3 07/11] bsd-user: sysctl helper funtions: sysctl_name2oid and sysctl_oidfmt Warner Losh
2023-02-16 23:33 ` [PATCH v3 08/11] bsd-user: common routine do_freebsd_sysctl_oid for all sysctl variants Warner Losh
2023-02-16 23:33 ` [PATCH v3 09/11] bsd-user: Start translation of arch-specific sysctls Warner Losh
2023-02-16 23:33 ` [PATCH v3 10/11] bsd-user: do_freebsd_sysctl helper for sysctl(2) Warner Losh
2023-02-16 23:33 ` [PATCH v3 11/11] bsd-user: implement sysctlbyname(2) Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b0959b-4af7-a432-4391-e57d26a81894@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=nox@jelal.kn-bremen.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rakuco@FreeBSD.org \
--cc=sbruno@FreeBSD.org \
--cc=sson@FreeBSD.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).