qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Ed Swierk" <eswierk@arastra.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] -redir revisited
Date: Wed, 14 Jun 2006 12:53:04 -0700	[thread overview]
Message-ID: <c1bf1cf0606141253k6f9213ekd511c1b7955f5803@mail.gmail.com> (raw)
In-Reply-To: <15BBCEEB-3503-4AFC-9211-182CFE9B7B1E@cordney.com>

On 6/5/06, René Korthaus <qemu-dev@cordney.com> wrote:
> I researched current qemu cvs and found out that the patch was
> integrated not complete but to 95%. There are two lines in slirp/
> misc.c that need a change (patch attached). Tested to work with Mac
> OS X host and debian guest i could reach the Apache running inside
> the guest via localhost:8080 with the appropriate -redir command.

It looks like kju: is based on qemu 0.8.0, which definitely had the
bug you found. However, this was fixed in 0.8.1. Did you try a current
version of qemu (0.8.1 or cvs) without your patch?

I'm having trouble seeing how your patch could help solve the redir
problem, since as far as I can tell, our_addr is no longer used for
anything at all. Grepping for our_addr comes up with a buch of hits
that are either #if 0'ed or irrelevant (e.g. get_dns_addr, which
references our_addr before our_addr has been set).

--Ed

  parent reply	other threads:[~2006-06-14 19:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05 12:47 [Qemu-devel] [PATCH] -redir revisited René Korthaus
2006-06-14 13:57 ` Fabrice Bellard
2006-06-14 16:26   ` René Korthaus
2006-06-14 17:08     ` Fabrice Bellard
2006-06-14 19:53 ` Ed Swierk [this message]
2006-06-15  9:32   ` René Korthaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1bf1cf0606141253k6f9213ekd511c1b7955f5803@mail.gmail.com \
    --to=eswierk@arastra.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).