From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H9UA4-0001hr-C5 for qemu-devel@nongnu.org; Tue, 23 Jan 2007 17:30:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H9UA2-0001hf-1c for qemu-devel@nongnu.org; Tue, 23 Jan 2007 17:30:39 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H9UA1-0001hc-T1 for qemu-devel@nongnu.org; Tue, 23 Jan 2007 17:30:37 -0500 Received: from [209.85.132.240] (helo=an-out-0708.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H9UA0-0000j3-Qk for qemu-devel@nongnu.org; Tue, 23 Jan 2007 17:30:37 -0500 Received: by an-out-0708.google.com with SMTP id d40so1519013and for ; Tue, 23 Jan 2007 14:30:32 -0800 (PST) Message-ID: Date: Tue, 23 Jan 2007 14:30:31 -0800 From: "Ed Swierk" Sender: eswierk@gmail.com Subject: Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation In-Reply-To: <45B68307.9090509@bellard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45B68307.9090509@bellard.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 1/23/07, Fabrice Bellard wrote: > OK, but avoid using mmap() in the device code. Moreover, files in the > BIOS directory are not writable. OK. Would it be better to do the following: - add a command-line option -seeprom that sets the file to use as backing store for the smbus_eeprom device - in main(), open and mmap the file if the -seeprom option is specified, otherwise allocate a temporary buffer - add a seeprom buffer argument to each machine's init(), ignored except for pc --Ed